From 761e83a5f38c5b0829dd48c6bbf6a6a901092f41 Mon Sep 17 00:00:00 2001 From: Ryan Cramer Date: Fri, 20 May 2022 08:42:39 -0400 Subject: [PATCH] Add @netcarver PR #226 to fix unintentional assignment in conditional, plus minor phpdoc update in InputfieldWrapper Co-authored-by: netcarver --- wire/core/InputfieldWrapper.php | 17 +++++++++++++++-- .../ProcessTemplate/ProcessTemplate.module | 4 ++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/wire/core/InputfieldWrapper.php b/wire/core/InputfieldWrapper.php index a89a7fa7..938dde23 100644 --- a/wire/core/InputfieldWrapper.php +++ b/wire/core/InputfieldWrapper.php @@ -478,7 +478,7 @@ class InputfieldWrapper extends Inputfield implements \Countable, \IteratorAggre * Note: string or array values for either argument require 3.0.196+. * * ~~~~~ - * // example 1: Get existing Inputfields and change order + * // example 1: Get existing Inputfields and insert first_name before last_name * $firstName = $form->getByName('first_name'); * $lastName = $form->getByName('last_name'); * $form->insertBefore($firstName, $lastName); @@ -504,7 +504,20 @@ class InputfieldWrapper extends Inputfield implements \Countable, \IteratorAggre /** * Insert one Inputfield after one that’s already there. * - * Note: string or array values for either argument require 3.0.196+. + * Note: string or array values for either argument require 3.0.196+. + * + * ~~~~~ + * // example 1: Get existing Inputfields, insert last_name after first_name + * $lastName = $form->getByName('last_name'); + * $firstName = $form->getByName('first_name'); + * $form->insertAfter($lastName, $firstName); + * + * // example 2: Same as above but use Inputfield names (3.0.196+) + * $form->insertBefore('last_name', 'first_name'); + * + * // example 3: Create new Inputfield and insert after first_name (3.0.196+) + * $form->insertAfter([ 'type' => 'text', 'name' => 'last_name' ], 'first_name'); + * ~~~~~ * * #pw-group-manipulation * diff --git a/wire/modules/Process/ProcessTemplate/ProcessTemplate.module b/wire/modules/Process/ProcessTemplate/ProcessTemplate.module index ac95c602..b25d0135 100644 --- a/wire/modules/Process/ProcessTemplate/ProcessTemplate.module +++ b/wire/modules/Process/ProcessTemplate/ProcessTemplate.module @@ -2821,9 +2821,9 @@ class ProcessTemplate extends Process implements ConfigurableModule { $value = $f->val(); if($sanitizerName === 'int') { $value = (int) $value; - } else if($sanitizerName = 'text') { + } else if($sanitizerName === 'text') { $value = $sanitizer->text($value); - } else if($sanitizerName = 'words') { + } else if($sanitizerName === 'words') { $value = $sanitizer->words($value); } else { // use as-is