mirror/processwire
1
0
Fork 0
mirror of https://github.com/processwire/processwire.git synced 2025-08-14 02:34:24 +02:00
Code Issues Releases Wiki Activity

Fix issue in Lister bookmarks where columns could be lost for a non-superuser owned bookmark when modifying an existing bookmark

Browse Source
This commit is contained in:
Ryan Cramer
2022-04-19 09:56:04 -04:00
parent 89d46632b3
commit 78ae5e3f56
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wire/modules/Process/ProcessPageLister/ProcessPageListerBookmarks.php
View File

@@ -534,7 +534,7 @@ class ProcessPageListerBookmarks extends Wire {
$bookmarkSelector = str_replace(', , ', ', ', $bookmarkSelector); $bookmarkSelector = str_replace(', , ', ', ', $bookmarkSelector);
$bookmarkSelector = trim($bookmarkSelector, ', '); $bookmarkSelector = trim($bookmarkSelector, ', ');
if($bookmarkID) { if($bookmarkID && $this->user->isSuperuser()) {
$bookmarkColumns = $input->post('bookmark_columns'); $bookmarkColumns = $input->post('bookmark_columns');
foreach($bookmarkColumns as $cnt => $column) { foreach($bookmarkColumns as $cnt => $column) {
$column = $sanitizer->name($column); $column = $sanitizer->name($column);
@@ -545,6 +545,8 @@ class ProcessPageListerBookmarks extends Wire {
} }
} }
$bookmarkColumns = array_values($bookmarkColumns); $bookmarkColumns = array_values($bookmarkColumns);
} else if($bookmarkID && $existingBookmark) {
$bookmarkColumns = $existingBookmark['columns'];
} else { } else {
$bookmarkColumns = $this->lister->columns; $bookmarkColumns = $this->lister->columns;
} }