mirror/processwire
1
0
Fork 0
mirror of https://github.com/processwire/processwire.git synced 2025-08-20 13:31:48 +02:00
Code Issues Releases Wiki Activity

Add ProcessField detection for invalid Page field showIf/requiredIf dependencies per processwire/processwire-issues#509

Browse Source
This commit is contained in:
Ryan Cramer
2018-03-07 08:11:42 -05:00
parent a166c22e71
commit b1454b31a4
1 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
wire/modules/Process/ProcessField/ProcessField.module
View File

@@ -1836,6 +1836,10 @@ class ProcessField extends Process implements ConfigurableModule {
if($name == 'name' && (!$this->field->id || $value !== $this->field->name)) {
if(!$this->isAllowedName($value)) continue;
}
if(($name == 'showIf' || $name == 'requiredIf') && strlen($value)) {
$this->checkInputfieldDependencySetting($inputfield);
}
$this->field->set($name, $value);
@@ -1869,6 +1873,36 @@ class ProcessField extends Process implements ConfigurableModule {
}
}
/**
* Check a showIf or requiredIf setting for potential problems
*
* @param Inputfield $inputfield Inputfield containing the setting (showIf/requiredIf)
*
*/
protected function checkInputfieldDependencySetting(Inputfield $inputfield) {
$label = sprintf($this->_('Error in setting “%s”'), $inputfield->getSetting('label'));
$value = $inputfield->attr('value');
$valueLabel = ' ' . sprintf($this->_('(you specified “%s”)'), $value);
if(empty($value)) return;
try {
$selectors = new Selectors($value);
} catch(\Exception $e) {
$this->error("$label - " . $this->_('Unable to validate') . $valueLabel);
return;
}
foreach($selectors as $selector) {
foreach($selector->fields() as $f) {
if(strpos($f, '.')) continue;
if(!strlen($selector->value())) continue;
$f = $this->wire('fields')->get($f);
if(!$f || !$f->type instanceof FieldtypePage) continue;
$v = implode('', $selector->values());
if(ctype_digit("$v")) continue; // validates
$this->error("$label - " . $this->_('This will not work because values must be page IDs') . $valueLabel);
}
}
}
/**
* Saves the submitted checkboxes from the "Overrides" tab
*