mirror/ripme
1
0
Fork 0
mirror of https://github.com/RipMeApp/ripme.git synced 2025-09-01 01:51:56 +02:00
Code Issues Releases Wiki Activity

junit5 VscoRipper test + fix it

Browse Source
This commit is contained in:
soloturn
2020-07-29 05:23:46 +02:00
parent 298c2c2ec3
commit 4dbffc660e
2 changed files with 5 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/test/java/com/rarchives/ripme/tst/ripper/rippers/RippersTest.java
View File

@@ -131,11 +131,6 @@ public class RippersTest {
Assertions.assertEquals(expected, actual); Assertions.assertEquals(expected, actual);
} }
@Deprecated
void assertEquals(String message, String expected, String actual) {
Assertions.assertEquals(expected, actual, message);
}
@Deprecated @Deprecated
void assertEquals(Object expected, Object actual) { void assertEquals(Object expected, Object actual) {
Assertions.assertEquals(expected, actual); Assertions.assertEquals(expected, actual);

20
src/test/java/com/rarchives/ripme/tst/ripper/rippers/VscoRipperTest.java
View File

@@ -2,6 +2,7 @@ package com.rarchives.ripme.tst.ripper.rippers;
import com.rarchives.ripme.ripper.rippers.VscoRipper; import com.rarchives.ripme.ripper.rippers.VscoRipper;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import java.io.IOException; import java.io.IOException;
@@ -21,25 +22,14 @@ public class VscoRipperTest extends RippersTest {
} }
/** /**
* Tests profile rip. * Tests profile rip., Prevents Bug #679 from happening again.
*
* @throws IOException
*/
@Test
public void testProfileRip() throws IOException {
VscoRipper ripper = new VscoRipper(new URL("https://vsco.co/jonathangodoy/images/1"));
testRipper(ripper);
}
/**
* Prevents Bug #679 from happening again.
* https://github.com/RipMeApp/ripme/issues/679 * https://github.com/RipMeApp/ripme/issues/679
* *
* @throws IOException * @throws IOException
*/ */
@Test @Test
public void testHyphenatedRip() throws IOException { public void testHyphenatedRip() throws IOException {
VscoRipper ripper = new VscoRipper(new URL("https://vsco.co/jolly-roger/images/1")); VscoRipper ripper = new VscoRipper(new URL("https://vsco.co/jolly-roger/gallery"));
testRipper(ripper); testRipper(ripper);
} }
@@ -50,11 +40,11 @@ public class VscoRipperTest extends RippersTest {
*/ */
@Test @Test
public void testGetGID() throws IOException { public void testGetGID() throws IOException {
URL url = new URL("https://vsco.co/minijello/media/571cd612542220261a123441"); URL url = new URL("https://vsco.co/jolly-roger/media/590359c4ade3041f2658f407");
VscoRipper ripper = new VscoRipper(url); VscoRipper ripper = new VscoRipper(url);
assertEquals("Failed to get GID", "minijello/571cd", ripper.getGID(url)); Assertions.assertEquals("jolly-roger/59035", ripper.getGID(url), "Failed to get GID");
} }
} }