From 74bfac0e3efc331588b6eebf8ce78ac0733ab066 Mon Sep 17 00:00:00 2001 From: Philipp Erhardt Date: Sun, 1 Dec 2019 11:45:45 +0100 Subject: [PATCH] String comparisons: don't use "reference equality" See https://stackoverflow.com/q/513832 for more details --- src/main/java/com/rarchives/ripme/utils/Http.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/rarchives/ripme/utils/Http.java b/src/main/java/com/rarchives/ripme/utils/Http.java index d2796b53..1b85005c 100644 --- a/src/main/java/com/rarchives/ripme/utils/Http.java +++ b/src/main/java/com/rarchives/ripme/utils/Http.java @@ -82,7 +82,7 @@ public class Http { String domain = String.join(".", parts); // Try to get cookies for this host from config cookieStr = Utils.getConfigString("cookies." + domain, ""); - if (cookieStr != "") { + if (cookieStr.equals("")) { cookieDomain = domain; // we found something, start parsing break; @@ -90,7 +90,7 @@ public class Http { parts = (String[]) ArrayUtils.remove(parts, 0); } - if (cookieStr != "") { + if (!cookieStr.equals("")) { cookiesParsed = RipUtils.getCookiesFromString(cookieStr.trim()); } } catch (MalformedURLException e) {