From 8cee44125226a82d63c22b406494b472a033d33c Mon Sep 17 00:00:00 2001 From: Kevin Jiang Date: Fri, 5 Jan 2018 17:11:46 -0500 Subject: [PATCH] Gfycat Tests & Fix for bad reddit submissions Added and restructured Gfycat tests. - Rips from reddit go in Reddit Test Suite - Direct rips from Gfycat go in the Gfycat Test Suite Task #361 - Some gfycat doesn't work --- .../tst/ripper/rippers/RedditRipperTest.java | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/test/java/com/rarchives/ripme/tst/ripper/rippers/RedditRipperTest.java b/src/test/java/com/rarchives/ripme/tst/ripper/rippers/RedditRipperTest.java index f20a21f2..f4ea70a1 100644 --- a/src/test/java/com/rarchives/ripme/tst/ripper/rippers/RedditRipperTest.java +++ b/src/test/java/com/rarchives/ripme/tst/ripper/rippers/RedditRipperTest.java @@ -5,6 +5,7 @@ import java.io.IOException; import java.net.URL; import com.rarchives.ripme.ripper.rippers.RedditRipper; +import com.rarchives.ripme.ripper.rippers.video.GfycatRipper; public class RedditRipperTest extends RippersTest { // https://github.com/RipMeApp/ripme/issues/253 - Disabled tests: RedditRipperTest#testRedditSubreddit*Rip is flaky @@ -22,4 +23,25 @@ public class RedditRipperTest extends RippersTest { RedditRipper ripper = new RedditRipper(new URL("http://www.reddit.com/r/UnrealGirls/comments/1ziuhl/in_class_veronique_popa/")); testRipper(ripper); } + + /** + * GFYCAT TEST + * Tests a good GfycatURL (no "/gifs/detail") + * @throws IOException + */ + public void testRedditGfyGoodURL() throws IOException { + GfycatRipper ripper = new GfycatRipper(new URL("https://www.reddit.com/r/bottesting/comments/7msozf/good_link/")); + testRipper(ripper); + } + + + /** + * GFYCAT TEST + * Tests a Bad URL with the "/gifs/detail" inside. + * @throws IOException + */ + public void testRedditGfyBadURL() throws IOException { + GfycatRipper ripper = new GfycatRipper(new URL("https://www.reddit.com/r/bottesting/comments/7msmhi/bad_link/")); + testRipper(ripper); + } }