diff --git a/src/main/java/com/rarchives/ripme/ripper/rippers/CfakeRipper.java b/src/main/java/com/rarchives/ripme/ripper/rippers/CfakeRipper.java index a217944d..d36019a7 100644 --- a/src/main/java/com/rarchives/ripme/ripper/rippers/CfakeRipper.java +++ b/src/main/java/com/rarchives/ripme/ripper/rippers/CfakeRipper.java @@ -49,9 +49,8 @@ public class CfakeRipper extends AbstractHTMLRipper { @Override public Document getNextPage(Document doc) throws IOException { - // Find next page - @SuppressWarnings("unused") - String nextUrl = ""; + + // We use comic-nav-next to the find the next page Element elem = doc.select("td > div.next > a").first(); if (elem == null) { diff --git a/src/main/java/com/rarchives/ripme/ripper/rippers/ErofusRipper.java b/src/main/java/com/rarchives/ripme/ripper/rippers/ErofusRipper.java index 715f1eb5..201983be 100644 --- a/src/main/java/com/rarchives/ripme/ripper/rippers/ErofusRipper.java +++ b/src/main/java/com/rarchives/ripme/ripper/rippers/ErofusRipper.java @@ -59,8 +59,8 @@ public class ErofusRipper extends AbstractHTMLRipper { public List getURLsFromPage(Document page) { logger.info(page); List imageURLs = new ArrayList<>(); - @SuppressWarnings("unused") - int x = 1; + + if (pageContainsImages(page)) { logger.info("Page contains images"); ripAlbum(page); diff --git a/src/main/java/com/rarchives/ripme/ripper/rippers/PorncomixRipper.java b/src/main/java/com/rarchives/ripme/ripper/rippers/PorncomixRipper.java index 11b87afa..82aa7cd9 100644 --- a/src/main/java/com/rarchives/ripme/ripper/rippers/PorncomixRipper.java +++ b/src/main/java/com/rarchives/ripme/ripper/rippers/PorncomixRipper.java @@ -12,7 +12,7 @@ import org.jsoup.nodes.Document; import org.jsoup.nodes.Element; import com.rarchives.ripme.ripper.AbstractHTMLRipper; -//import com.rarchives.ripme.utils.Http; + diff --git a/src/main/java/com/rarchives/ripme/ripper/rippers/PorncomixinfoRipper.java b/src/main/java/com/rarchives/ripme/ripper/rippers/PorncomixinfoRipper.java index 4526d401..3f75a73a 100644 --- a/src/main/java/com/rarchives/ripme/ripper/rippers/PorncomixinfoRipper.java +++ b/src/main/java/com/rarchives/ripme/ripper/rippers/PorncomixinfoRipper.java @@ -43,7 +43,7 @@ public class PorncomixinfoRipper extends AbstractHTMLRipper { @Override public Document getNextPage(Document doc) throws IOException { - // Find next page + // We use comic-nav-next to the find the next page Element elem = doc.select("a.next_page").first(); diff --git a/src/test/java/com/rarchives/ripme/tst/ripper/rippers/DeviantartRipperTest.java b/src/test/java/com/rarchives/ripme/tst/ripper/rippers/DeviantartRipperTest.java index 1a23c4ae..81e6f831 100644 --- a/src/test/java/com/rarchives/ripme/tst/ripper/rippers/DeviantartRipperTest.java +++ b/src/test/java/com/rarchives/ripme/tst/ripper/rippers/DeviantartRipperTest.java @@ -48,6 +48,11 @@ public class DeviantartRipperTest extends RippersTest { @Disabled("Broken ripper") public void testGetGalleryIDAndUsername() throws IOException, URISyntaxException { URL url = new URI("https://www.deviantart.com/airgee/gallery/").toURL(); + DeviantartRipper ripper = new DeviantartRipper(url); + Document doc = Http.url(url).get(); + // Had to comment because of refactoring/style change + // assertEquals("airgee", ripper.getUsername(doc)); + // assertEquals("714589", ripper.getGalleryID(doc)); } @Test