From aaa662e2827f845c09b13a033f20b18e767aabee Mon Sep 17 00:00:00 2001 From: cyian-1756 Date: Wed, 12 Sep 2018 07:09:32 -0400 Subject: [PATCH 1/2] Fixed viewcomic ripper --- .../com/rarchives/ripme/ripper/rippers/ViewcomicRipper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/rarchives/ripme/ripper/rippers/ViewcomicRipper.java b/src/main/java/com/rarchives/ripme/ripper/rippers/ViewcomicRipper.java index d2ea95fc..27015a06 100644 --- a/src/main/java/com/rarchives/ripme/ripper/rippers/ViewcomicRipper.java +++ b/src/main/java/com/rarchives/ripme/ripper/rippers/ViewcomicRipper.java @@ -69,7 +69,7 @@ public class ViewcomicRipper extends AbstractHTMLRipper { @Override public List getURLsFromPage(Document doc) { List result = new ArrayList(); - for (Element el : doc.select("div.pinbin-copy > a > img")) { + for (Element el : doc.select("div.separator > a > img")) { result.add(el.attr("src")); } return result; From d7b50a94e34edcda2125abf0e21e90e88e236583 Mon Sep 17 00:00:00 2001 From: cyian-1756 Date: Wed, 12 Sep 2018 07:09:55 -0400 Subject: [PATCH 2/2] Added viewcomic unit test --- .../ripme/tst/ripper/rippers/ViewcomicRipperTest.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/test/java/com/rarchives/ripme/tst/ripper/rippers/ViewcomicRipperTest.java b/src/test/java/com/rarchives/ripme/tst/ripper/rippers/ViewcomicRipperTest.java index ac9c49ee..3d9ed309 100644 --- a/src/test/java/com/rarchives/ripme/tst/ripper/rippers/ViewcomicRipperTest.java +++ b/src/test/java/com/rarchives/ripme/tst/ripper/rippers/ViewcomicRipperTest.java @@ -6,5 +6,8 @@ import java.net.URL; import com.rarchives.ripme.ripper.rippers.ViewcomicRipper; public class ViewcomicRipperTest extends RippersTest { - // TODO add a test + public void testViewcomicRipper() throws IOException { + ViewcomicRipper ripper = new ViewcomicRipper(new URL("https://view-comic.com/batman-no-mans-land-vol-1/")); + testRipper(ripper); + } } \ No newline at end of file