Thread -> runnable

src/main/java/com/rarchives/ripme/ripper/DownloadFileThread.java

@@ -24,7 +24,7 @@ import com.rarchives.ripme.utils.Utils;
  * Thread for downloading files. Includes retry logic, observer notifications,
  * and other goodies.
  */
-class DownloadFileThread extends Thread {
+class DownloadFileThread implements Runnable {
     private static final Logger logger = LogManager.getLogger(DownloadFileThread.class);
 
     private String referrer = "";

src/main/java/com/rarchives/ripme/ripper/DownloadThreadPool.java

@@ -35,10 +35,10 @@ public class DownloadThreadPool {
     }
     /**
      * For adding threads to execution pool.
-     * @param t 
+     * @param t
      *      Thread to be added.
      */
-    public void addThread(Thread t) {
+    public void addThread(Runnable t) {
         threadPool.execute(t);
     }
 

src/main/java/com/rarchives/ripme/ripper/DownloadVideoThread.java

@@ -20,15 +20,15 @@ import org.apache.logging.log4j.Logger;
  * Thread for downloading files.
  * Includes retry logic, observer notifications, and other goodies.
  */
-class DownloadVideoThread extends Thread {
+class DownloadVideoThread implements Runnable {
 
     private static final Logger logger = LogManager.getLogger(DownloadVideoThread.class);
 
-    private URL url;
+    private final URL url;
-    private Path saveAs;
+    private final Path saveAs;
-    private String prettySaveAs;
+    private final String prettySaveAs;
-    private AbstractRipper observer;
+    private final AbstractRipper observer;
-    private int retries;
+    private final int retries;
 
     public DownloadVideoThread(URL url, Path saveAs, AbstractRipper observer) {
         super();
@@ -43,6 +43,7 @@ class DownloadVideoThread extends Thread {
      * Attempts to download the file. Retries as needed.
      * Notifies observers upon completion/error/warn.
      */
+    @Override
     public void run() {
         try {
             observer.stopCheck();

src/main/java/com/rarchives/ripme/ripper/rippers/DeviantartRipper.java

@@ -518,8 +518,8 @@ public class DeviantartRipper extends AbstractHTMLRipper {
 	 * @author MrPlaygon
 	 *
 	 */
-	private class DeviantartImageThread extends Thread {
+	private class DeviantartImageThread implements Runnable {
-		private URL url;
+		private final URL url;
 
 		public DeviantartImageThread(URL url) {
 			this.url = url;

src/main/java/com/rarchives/ripme/ripper/rippers/E621Ripper.java

@@ -193,10 +193,10 @@ public class E621Ripper extends AbstractHTMLRipper {
         return url;
     }
 
-    public class E621FileThread extends Thread {
+    public class E621FileThread implements Runnable {
 
-        private URL url;
+        private final URL url;
-        private String index;
+        private final String index;
 
         public E621FileThread(URL url, String index) {
             this.url = url;

src/main/java/com/rarchives/ripme/ripper/rippers/EHentaiRipper.java

@@ -206,7 +206,7 @@ public class EHentaiRipper extends AbstractHTMLRipper {
      * <p>
      * Handles case when site has IP-banned the user.
      */
-    private class EHentaiImageThread extends Thread {
+    private class EHentaiImageThread implements Runnable {
         private final URL url;
         private final int index;
         private final Path workingDir;

src/main/java/com/rarchives/ripme/ripper/rippers/HentaidudeRipper.java

@@ -84,7 +84,7 @@ public class HentaidudeRipper extends AbstractSingleFileRipper {
         return hentaidudeThreadPool;
     }
 
-    private class HentaidudeDownloadThread extends Thread {
+    private class HentaidudeDownloadThread implements Runnable {
 
         private URL url;
 

src/main/java/com/rarchives/ripme/ripper/rippers/HqpornerRipper.java

@@ -130,7 +130,7 @@ public class HqpornerRipper extends AbstractHTMLRipper {
 		return true;
 	}
 
-	private class HqpornerDownloadThread extends Thread {
+	private class HqpornerDownloadThread implements Runnable {
 
 		private URL hqpornerVideoPageUrl;
 		//private int index;

src/main/java/com/rarchives/ripme/ripper/rippers/ImagebamRipper.java

@@ -117,9 +117,9 @@ public class ImagebamRipper extends AbstractHTMLRipper {
      *
      * Handles case when site has IP-banned the user.
      */
-    private class ImagebamImageThread extends Thread {
+    private class ImagebamImageThread implements Runnable {
-        private URL url; //link to "image page"
+        private final URL url; //link to "image page"
-        private int index; //index in album
+        private final int index; //index in album
 
         ImagebamImageThread(URL url, int index) {
             super();

src/main/java/com/rarchives/ripme/ripper/rippers/ImagevenueRipper.java

@@ -79,9 +79,9 @@ public class ImagevenueRipper extends AbstractHTMLRipper {
      *
      * Handles case when site has IP-banned the user.
      */
-    private class ImagevenueImageThread extends Thread {
+    private class ImagevenueImageThread implements Runnable {
-        private URL url;
+        private final URL url;
-        private int index;
+        private final int index;
 
         ImagevenueImageThread(URL url, int index) {
             super();

src/main/java/com/rarchives/ripme/ripper/rippers/ListalRipper.java

@@ -182,10 +182,10 @@ public class ListalRipper extends AbstractHTMLRipper {
         throw new MalformedURLException("Unable to fetch the gid for given url.");
     }
 
-    private class ListalImageDownloadThread extends Thread {
+    private class ListalImageDownloadThread implements Runnable {
 
-        private URL url;
+        private final URL url;
-        private int index;
+        private final int index;
 
         public ListalImageDownloadThread(URL url, int index) {
             super();

src/main/java/com/rarchives/ripme/ripper/rippers/LusciousRipper.java

@@ -120,7 +120,7 @@ public class LusciousRipper extends AbstractHTMLRipper {
         }
     }
 
-    public class LusciousDownloadThread extends Thread {
+    public class LusciousDownloadThread implements Runnable {
         private final URL url;
         private final int index;
 

src/main/java/com/rarchives/ripme/ripper/rippers/MotherlessRipper.java

@@ -152,9 +152,9 @@ public class MotherlessRipper extends AbstractHTMLRipper {
     /**
      * Helper class to find and download images found on "image" pages
      */
-    private class MotherlessImageThread extends Thread {
+    private class MotherlessImageThread implements Runnable {
-        private URL url;
+        private final URL url;
-        private int index;
+        private final int index;
 
         MotherlessImageThread(URL url, int index) {
             super();

src/main/java/com/rarchives/ripme/ripper/rippers/NfsfwRipper.java

@@ -196,10 +196,10 @@ public class NfsfwRipper extends AbstractHTMLRipper {
     /**
      * Helper class to find and download images found on "image" pages
      */
-    private class NfsfwImageThread extends Thread {
+    private class NfsfwImageThread implements Runnable {
-        private URL url;
+        private final URL url;
-        private String subdir;
+        private final String subdir;
-        private int index;
+        private final int index;
 
         NfsfwImageThread(URL url, String subdir, int index) {
             super();

src/main/java/com/rarchives/ripme/ripper/rippers/PornhubRipper.java

@@ -126,9 +126,9 @@ public class PornhubRipper extends AbstractHTMLRipper {
      *
      * Handles case when site has IP-banned the user.
      */
-    private class PornhubImageThread extends Thread {
+    private class PornhubImageThread implements Runnable {
-        private URL url;
+        private final URL url;
-        private int index;
+        private final int index;
 
         PornhubImageThread(URL url, int index, Path workingDir) {
             super();