1
0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-02-01 05:16:10 +01:00
slate/Contributing.md

114 lines
4.8 KiB
Markdown
Raw Normal View History

2016-07-12 22:23:27 -07:00
# Contributing
Want to contribute to Slate? That would be awesome!
2018-02-06 21:29:55 -08:00
* [Reporting Bugs](#reporting-bugs)
* [Asking Questions](#asking-questions)
* [Submitting Pull Requests](#submitting-pull-requests)
* [Running Examples](#running-examples)
* [Running Tests](#running-tests)
* [Running Benchmarks](#running-benchmarks)
* [Adding Browser Support](#adding-browser-support)
* [Testing Input Methods](#testing-input-methods)
* [Debugging Slate Methods](#debugging-slate-methods)
* [Publishing Releases](#publishing-releases)
2016-07-28 13:09:29 -07:00
## Reporting Bugs
If you run into any weird behavior while using Slate, feel free to open a new issue in this repository! Please run a **search before opening** a new issue, to make sure that someone else hasn't already reported or solved the bug you've found.
2017-08-15 10:36:10 -07:00
Any issue you open must include:
2018-02-06 21:29:55 -08:00
* A [JSFiddle](https://jsfiddle.net/fj9dvhom/1/) that reproduces the bug with a minimal setup.
* A GIF showing the issue in action. (Using something like [RecordIt](http://recordit.co/).)
* A clear explanation of what the issue is.
2016-07-28 13:09:29 -07:00
Here's a [JSFiddle template for Slate](https://jsfiddle.net/fj9dvhom/1/) to get you started:
2016-07-28 13:09:29 -07:00
[![](./docs/images/jsfiddle.png)](https://jsfiddle.net/fj9dvhom/1/)
2016-07-28 13:09:29 -07:00
## Asking Questions
2016-07-28 13:13:44 -07:00
We've also got a [Slate Slack team](https://slate-slack.herokuapp.com) where you can ask questions and get answers from other people using Slate:
2016-07-28 13:09:29 -07:00
2016-07-28 13:13:44 -07:00
[![](./docs/images/slack.png)](https://slate-slack.herokuapp.com)
Please use the Slack instead of asking questions in issues, since we want to reserve issues for keeping track of bugs and features. We close questions in issues so that maintaining the project isn't overwhelming.
2016-07-28 13:13:44 -07:00
## Submitting Pull Requests
2016-07-28 13:09:29 -07:00
All pull requests are super welcomed and greatly appreciated! Easy issues are marked with an [`easy-one`](https://github.com/ianstormtaylor/slate/issues?q=is%3Aopen+is%3Aissue+label%3Aeasy-one) label if you're looking for a simple place to get familiar with the code base.
Please include tests and docs with every pull request!
## Running Examples
Check out the [Examples readme](./examples) to see how to get the examples running locally!
2016-07-28 13:09:29 -07:00
## Running Tests
2016-07-12 22:23:27 -07:00
To run the tests, you need to have the Slate repository cloned to your computer. After that, you need to `cd` into the directory where you cloned it, and install the dependencies with `yarn` and bootstrap the monorepo:
```
yarn install
yarn bootstrap
```
Then run the tests with:
2016-07-12 22:26:57 -07:00
```
yarn test
2016-07-12 22:26:57 -07:00
```
2016-07-12 22:23:27 -07:00
To keep the source rebuilding on every file change, you need to run an additional watching command in a separate process:
2016-07-12 22:23:27 -07:00
```
yarn watch
2016-07-12 22:23:27 -07:00
```
2018-02-06 21:29:55 -08:00
If you need to debug something, you can add a `debugger` line to the source, and then run `yarn test debug`.
If you only want to run a specific test or tests, you can run `yarn test --fgrep="slate-react rendering"` flag which will filter the tests being run by grepping for the string in each test.
## Running Benchmarks
To run the benchmarks, first make some changes to the source that you want to benchmark. Now that you're ready, you need to save a "baseline" for what the performance was before you made you change.
2016-07-12 22:23:27 -07:00
To do that, stash your changes and save the benchmarks:
2016-07-12 22:23:27 -07:00
```
git stash
yarn benchmark:save
2016-07-12 22:23:27 -07:00
```
Then once the reference has been saved, unstash your changes and run the benchmarks to see a comparison:
2016-07-12 22:23:27 -07:00
```
git stash pop
yarn benchmark
```
2016-07-12 22:23:27 -07:00
There will be some subtle changes in iteration speed always, but the comparison reporter will highlight any changes that seem meaningful. You can run `benchmark` multiple times to ensure the speed up persists.
2016-07-12 22:23:27 -07:00
2016-07-28 13:13:44 -07:00
## Adding Browser Support
2016-07-12 22:23:27 -07:00
Slate aims to targeted all of the modern browsers, and eventually the modern mobile platforms. Right now browser support is limited to the latest versions of [Chrome](https://www.google.com/chrome/browser/desktop/), [Firefox](https://www.mozilla.org/en-US/firefox/new/), and [Safari](http://www.apple.com/safari/), but if you are interested in adding support for another modern platform, that is welcomed!
## Testing Input Methods
[Here's a helpful page](https://github.com/Microsoft/vscode/wiki/IME-Test) detailing how to test various input scenarios on Windows, Mac and Linux.
2017-09-11 19:30:04 -07:00
## Debugging Slate Methods
Slate makes use of [debug](https://github.com/visionmedia/debug) to log information about various methods. You can [enable the logger in the browser](https://github.com/visionmedia/debug#browser-support) by setting `localStorage.debug = "*"` (to log methods on all modules) or to a single namespace (e.g. `slate:editor`). Look for `const debug = Debug('<namespace>')` to get the namespace of various modules.
2017-09-11 19:30:04 -07:00
## Publishing Releases
Since we use [Lerna](https://lernajs.io) to manage the Slate packages this is fairly easy, **but** you must make sure you are using `npm` to run the release script, because using `yarn` results in failures. So just run:
```js
2018-02-06 21:29:55 -08:00
npm run release
2017-09-11 19:30:04 -07:00
```
And follow the prompts Lerna gives you.