1
0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-13 02:34:05 +02:00

fix: normalizeNode (#5311)

* fix

* Create large-worms-jog.md

* Update large-worms-jog.md

* Update large-worms-jog.md

* Update large-worms-jog.md

* fix
This commit is contained in:
Ziad Beyens
2023-02-24 00:10:08 +01:00
committed by GitHub
parent b94254d694
commit 0ac72a626c
4 changed files with 15 additions and 7 deletions

View File

@@ -0,0 +1,5 @@
---
'slate': patch
---
Fix #5295 regression. `editor.shouldNormalize` new option: `initialDirtyPathsLength: number`

View File

@@ -420,7 +420,7 @@ Check if a value is a void `Element` object.
Override this method to prevent normalizing the editor.
Options: `{ iteration: number; dirtyPaths: Path[]; operation?: Operation(entry: NodeEntry, { operation }`
Options: `{ dirtyPaths: Path[]; initialDirtyPathsLength: number; iteration: number; operation?: Operation }`
### Callback method

View File

@@ -414,8 +414,8 @@ export const createEditor = (): Editor => {
}
},
shouldNormalize: ({ iteration, dirtyPaths }) => {
const maxIterations = dirtyPaths.length * 42 // HACK: better way?
shouldNormalize: ({ iteration, initialDirtyPathsLength }) => {
const maxIterations = initialDirtyPathsLength * 42 // HACK: better way?
if (iteration > maxIterations) {
throw new Error(

View File

@@ -85,6 +85,7 @@ export interface BaseEditor {
operation,
}: {
iteration: number
initialDirtyPathsLength: number
dirtyPaths: Path[]
operation?: Operation
}) => boolean
@@ -1072,15 +1073,16 @@ export const Editor: EditorInterface = {
}
}
const dirtyPaths = getDirtyPaths(editor)
let dirtyPaths = getDirtyPaths(editor)
const initialDirtyPathsLength = dirtyPaths.length
let iteration = 0
while (getDirtyPaths(editor).length !== 0) {
while (dirtyPaths.length !== 0) {
if (
!editor.shouldNormalize({
dirtyPaths,
iteration,
dirtyPaths: getDirtyPaths(editor),
initialDirtyPathsLength,
operation,
})
) {
@@ -1095,6 +1097,7 @@ export const Editor: EditorInterface = {
editor.normalizeNode(entry, { operation })
}
iteration++
dirtyPaths = getDirtyPaths(editor)
}
})
},