From 0b70ca85d5550ac5fda1473dafa8dc03c1bdacfc Mon Sep 17 00:00:00 2001 From: Irwan Fario Subastian Date: Thu, 2 Nov 2017 12:43:24 +1100 Subject: [PATCH] fix scrolling on slate inside scrollable container that is not a window (#1369) --- packages/slate-react/src/utils/scroll-to-selection.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/slate-react/src/utils/scroll-to-selection.js b/packages/slate-react/src/utils/scroll-to-selection.js index f13d4055d..121a12bf5 100644 --- a/packages/slate-react/src/utils/scroll-to-selection.js +++ b/packages/slate-react/src/utils/scroll-to-selection.js @@ -23,7 +23,7 @@ const OVERFLOWS = [ function findScrollContainer(el) { const window = getWindow(el) let parent = el.parentNode - let scroller = window + let scroller while (!scroller) { if (!parent.parentNode) break @@ -38,6 +38,8 @@ function findScrollContainer(el) { parent = parent.parentNode } + if (!scroller) return window + return scroller }