mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-29 09:59:48 +02:00
Code Issues Releases Wiki Activity

Fix selections with non-void non-editable focus (#5716)

Browse Source 
* Fix selections with non-void non-editable focus

"Non-void non-editable" refers to `contentEditable={false}` DOM nodes
that are rendered by a Slate element render but which are not void
elements. For instance, [the checkboxes in the checklists example][1].

[1]: 7e77a932f0/site/examples/check-lists.tsx (L153-L170)

* fixup! Fix selections with non-void non-editable focus

Optimize leaf node search

* fixup! Fix selections with non-void non-editable focus

Rename `focusNodeSelectable` to `focusNodeIsSelectable`

A more accurate name given this PR's changes.

* fixup! Fix selections with non-void non-editable focus

Remove inapplicable `if` branch

* fixup! Fix selections with non-void non-editable focus

Improve comment
This commit is contained in:
Ty Mick
2024-09-12 10:53:44 -07:00
committed by GitHub
parent 34c17af979
commit 10abeff84f
4 changed files with 87 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/brown-ears-tap.md Normal file
View File

@@ -0,0 +1,5 @@
---
'slate-react': patch
---
Fix selections with non-void non-editable focus