mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-09-03 12:12:39 +02:00
Code Issues Releases Wiki Activity

Fix invalid transform path in move_node operation (#2324)

Browse Source 
* Add failing deleteAtRange test

* Fix invalid move node path increment (fixes #2291)

* Add another three block delete all test without any void nodes

* Test the correct variables in transform path (move_node)
This commit is contained in:
Per-Kristian Nordnes
2018-10-25 21:36:53 +02:00
committed by Ian Storm Taylor
parent 4e906b3be2
commit 125ea00245
3 changed files with 68 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/slate/src/utils/path-utils.js
View File

@@ -342,6 +342,11 @@ function transform(path, operation) {
const { newPath: np } = operation
const npIndex = np.size - 1
const npEqual = isEqual(np, path)
if (isEqual(p, np)) {
return List([path])
}
const npYounger = isYounger(np, path)
const npAbove = isAbove(np, path)

31
packages/slate/test/commands/at-current-range/delete/non-void-triple.js Normal file
View File

@@ -0,0 +1,31 @@
/** @jsx h */
import h from '../../../helpers/h'
export default function(change) {
change.delete()
}
export const input = (
<value>
<document>
<paragraph>
<anchor />1
</paragraph>
<paragraph>2</paragraph>
<paragraph>
3<focus />
</paragraph>
</document>
</value>
)
export const output = (
<value>
<document>
<paragraph>
<cursor />
</paragraph>
</document>
</value>
)

32
packages/slate/test/commands/at-current-range/delete/void-inline-as-last-with-non-void-previous-siblings.js Normal file
View File

@@ -0,0 +1,32 @@
/** @jsx h */
import h from '../../../helpers/h'
export default function(change) {
change.delete()
}
export const input = (
<value>
<document>
<paragraph>
<anchor />Hi
</paragraph>
<paragraph>there</paragraph>
<paragraph>
<emoji />
<focus />
</paragraph>
</document>
</value>
)
export const output = (
<value>
<document>
<paragraph>
<cursor />
</paragraph>
</document>
</value>
)