mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-31 10:51:44 +02:00
Code Issues Releases Wiki Activity

Fix dirty path normalization on move_node (#2536)

Browse Source 
* Add failing tests on undo nested node merge

* Fix PathUtils transform on move_node operations
This commit is contained in:
Charley DAVID
2019-01-29 22:10:35 -02:00
committed by Ian Storm Taylor
parent 1ce7c7cc89
commit 1564c3a031
4 changed files with 102 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/slate/src/utils/path-utils.js
View File

@@ -351,9 +351,17 @@ function transform(path, operation) {
const npAbove = isAbove(np, path) const npAbove = isAbove(np, path)
if (pAbove) { if (pAbove) {
path = np.concat(path.slice(p.size)) if (isAfter(np, p)) {
path = decrement(np, 1, min(np, p) - 1).concat(path.slice(p.size))
} else {
path = np.concat(path.slice(p.size))
}
} else if (pEqual) { } else if (pEqual) {
path = np if (isAfter(np, p)) {
path = decrement(np, 1, min(np, p) - 1)
} else {
path = np
}
} else { } else {
if (pYounger) { if (pYounger) {
path = decrement(path, 1, pIndex) path = decrement(path, 1, pIndex)

30
packages/slate/test/commands/at-current-range/delete-backward/join-nested-blocks-different-depth.js Normal file
View File

@@ -0,0 +1,30 @@
/** @jsx h */
import h from '../../../helpers/h'
export default function(editor) {
editor.deleteBackward()
}
export const input = (
<value>
<document>
<paragraph>Hello</paragraph>
<list>
<item>
<cursor />world!
</item>
</list>
</document>
</value>
)
export const output = (
<value>
<document>
<paragraph>
Hello<cursor />world!
</paragraph>
</document>
</value>
)

33
packages/slate/test/history/undo/delete-backward-nested-blocks.js Normal file
View File

@@ -0,0 +1,33 @@
/** @jsx h */
import h from '../../helpers/h'
export default function(editor) {
editor.deleteBackward().undo()
}
export const input = (
<value>
<document>
<paragraph>Hello</paragraph>
<list>
<item>
<cursor />world!
</item>
</list>
</document>
</value>
)
export const output = (
<value>
<document>
<paragraph>Hello</paragraph>
<list>
<item>
<cursor />world!
</item>
</list>
</document>
</value>
)

29
packages/slate/test/history/undo/delete-backward.js Normal file
View File

@@ -0,0 +1,29 @@
/** @jsx h */
import h from '../../helpers/h'
export default function(editor) {
editor.deleteBackward().undo()
}
export const input = (
<value>
<document>
<paragraph>Hello</paragraph>
<paragraph>
<cursor />world!
</paragraph>
</document>
</value>
)
export const output = (
<value>
<document>
<paragraph>Hello</paragraph>
<paragraph>
<cursor />world!
</paragraph>
</document>
</value>
)