From 220f2d2ce6dffcc1a0f2ea1e8725601b8ea1949b Mon Sep 17 00:00:00 2001 From: Seiichi Nishikata Date: Fri, 13 Aug 2021 19:52:42 +0900 Subject: [PATCH] Fix invalid cursor when IME converting (#4450) --- .changeset/fix-ime-cursor-position.md | 5 +++++ packages/slate-react/src/components/editable.tsx | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/fix-ime-cursor-position.md diff --git a/.changeset/fix-ime-cursor-position.md b/.changeset/fix-ime-cursor-position.md new file mode 100644 index 000000000..fb4b2f7cb --- /dev/null +++ b/.changeset/fix-ime-cursor-position.md @@ -0,0 +1,5 @@ +--- +'slate-react': patch +--- + +Changed so that the onKeyDown event do not fired while IME converting. diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx index d862b1853..6393f1058 100644 --- a/packages/slate-react/src/components/editable.tsx +++ b/packages/slate-react/src/components/editable.tsx @@ -912,6 +912,7 @@ export const Editable = (props: EditableProps) => { (event: React.KeyboardEvent) => { if ( !readOnly && + !state.isComposing && hasEditableTarget(editor, event.target) && !isEventHandled(event, attributes.onKeyDown) ) {