From 3f0f55ff38fd57ea71d33924990d098e5844b418 Mon Sep 17 00:00:00 2001
From: Dundercover <dundercover@gmail.com>
Date: Fri, 9 Nov 2018 17:29:22 +0100
Subject: [PATCH] Do not show placeholder when document contains multiple text
 nodes (#2403)

---
 packages/slate-react/src/plugins/react.js     |  3 +-
 .../multiple-blocks-with-single-empty-text.js | 46 +++++++++++++++++
 .../placeholder/single-block-with-inline.js   | 49 +++++++++++++++++++
 .../single-block-with-single-empty-text.js    | 37 ++++++++++++++
 4 files changed, 134 insertions(+), 1 deletion(-)
 create mode 100644 packages/slate-react/test/rendering/fixtures/placeholder/multiple-blocks-with-single-empty-text.js
 create mode 100644 packages/slate-react/test/rendering/fixtures/placeholder/single-block-with-inline.js
 create mode 100644 packages/slate-react/test/rendering/fixtures/placeholder/single-block-with-single-empty-text.js

diff --git a/packages/slate-react/src/plugins/react.js b/packages/slate-react/src/plugins/react.js
index a66410ecf..56440bffc 100644
--- a/packages/slate-react/src/plugins/react.js
+++ b/packages/slate-react/src/plugins/react.js
@@ -120,7 +120,8 @@ function ReactPlugin(options = {}) {
         when: (editor, node) =>
           node.object === 'document' &&
           node.text === '' &&
-          node.nodes.size === 1,
+          node.nodes.size === 1 &&
+          node.getTexts().size === 1,
       })
     )
   }
diff --git a/packages/slate-react/test/rendering/fixtures/placeholder/multiple-blocks-with-single-empty-text.js b/packages/slate-react/test/rendering/fixtures/placeholder/multiple-blocks-with-single-empty-text.js
new file mode 100644
index 000000000..ce388d001
--- /dev/null
+++ b/packages/slate-react/test/rendering/fixtures/placeholder/multiple-blocks-with-single-empty-text.js
@@ -0,0 +1,46 @@
+/** @jsx h */
+
+import h from '../../../helpers/h'
+
+export const props = {
+  placeholder: 'placeholder text',
+}
+
+export const value = (
+  <value>
+    <document>
+      <paragraph>
+        <text />
+      </paragraph>
+      <paragraph>
+        <text />
+      </paragraph>
+    </document>
+  </value>
+)
+
+export const output = `
+<div data-slate-editor="true" contenteditable="true" role="textbox">
+    <div style="position:relative">
+        <span>
+            <span data-slate-leaf="true">
+                <span data-slate-zero-width="n" data-slate-length="0">
+                    <br>
+                </span>
+            </span>
+        </span>
+    </div>
+    <div style="position:relative">
+        <span>
+            <span data-slate-leaf="true">
+                <span data-slate-zero-width="n" data-slate-length="0">
+                    <br>
+                </span>
+            </span>
+        </span>
+    </div>
+</div>
+`
+  .split('\n')
+  .map(l => l.trim())
+  .join('')
diff --git a/packages/slate-react/test/rendering/fixtures/placeholder/single-block-with-inline.js b/packages/slate-react/test/rendering/fixtures/placeholder/single-block-with-inline.js
new file mode 100644
index 000000000..cbd65ed85
--- /dev/null
+++ b/packages/slate-react/test/rendering/fixtures/placeholder/single-block-with-inline.js
@@ -0,0 +1,49 @@
+/** @jsx h */
+
+import h from '../../../helpers/h'
+
+export const props = {
+  placeholder: 'placeholder text',
+}
+
+export const value = (
+  <value>
+    <document>
+      <paragraph>
+        <inline type="link">
+          <text />
+        </inline>
+        <text />
+      </paragraph>
+    </document>
+  </value>
+)
+
+export const output = `
+<div data-slate-editor="true" contenteditable="true" role="textbox">
+    <div style="position:relative">
+        <span>
+            <span data-slate-leaf="true">
+                <span data-slate-zero-width="z" data-slate-length="0"></span>
+            </span>
+        </span>
+        <span style="position:relative">
+            <span>
+                <span data-slate-leaf="true">
+                    <span data-slate-zero-width="z" data-slate-length="0"></span>
+                </span>
+            </span>
+        </span>
+        <span>
+            <span data-slate-leaf="true">
+                <span data-slate-zero-width="n" data-slate-length="0">
+                    <br>
+                </span>
+            </span>
+        </span>
+    </div>
+</div>
+`
+  .split('\n')
+  .map(l => l.trim())
+  .join('')
diff --git a/packages/slate-react/test/rendering/fixtures/placeholder/single-block-with-single-empty-text.js b/packages/slate-react/test/rendering/fixtures/placeholder/single-block-with-single-empty-text.js
new file mode 100644
index 000000000..5ca925227
--- /dev/null
+++ b/packages/slate-react/test/rendering/fixtures/placeholder/single-block-with-single-empty-text.js
@@ -0,0 +1,37 @@
+/** @jsx h */
+
+import h from '../../../helpers/h'
+
+export const props = {
+  placeholder: 'placeholder text',
+}
+
+export const value = (
+  <value>
+    <document>
+      <paragraph>
+        <text />
+      </paragraph>
+    </document>
+  </value>
+)
+
+export const output = `
+<div data-slate-editor="true" contenteditable="true" role="textbox">
+  <div style="position:relative">
+    <span>
+      <span data-slate-leaf="true">
+        <span contenteditable="false" style="pointer-events:none;display:inline-block;width:0;max-width:100%;white-space:nowrap;opacity:0.333">
+            placeholder text
+        </span>
+        <span data-slate-zero-width="n" data-slate-length="0">
+            <br>
+        </span>
+      </span>
+    </span>
+  </div>
+</div>
+`
+  .split('\n')
+  .map(l => l.trim())
+  .join('')