From 411e5a193bd639fb743c2253a5f5e43a5949b100 Mon Sep 17 00:00:00 2001
From: Andrew Herron <thespyder@programmer.net>
Date: Wed, 2 Jun 2021 04:22:54 +1000
Subject: [PATCH] Don't import slate-history in slate-react (#4266)
---
.changeset/bright-cameras-drum.md | 5 +++++
packages/slate-react/package.json | 1 -
packages/slate-react/src/components/editable.tsx | 11 ++++++-----
3 files changed, 11 insertions(+), 6 deletions(-)
create mode 100644 .changeset/bright-cameras-drum.md
diff --git a/.changeset/bright-cameras-drum.md b/.changeset/bright-cameras-drum.md
new file mode 100644
index 000000000..fe53a7771
--- /dev/null
+++ b/.changeset/bright-cameras-drum.md
@@ -0,0 +1,5 @@
+---
+'slate-react': patch
+---
+
+Removed accidental bundling of `slate-history` inside `slate-react`
diff --git a/packages/slate-react/package.json b/packages/slate-react/package.json
index 97ef6ac85..95450d06d 100644
--- a/packages/slate-react/package.json
+++ b/packages/slate-react/package.json
@@ -25,7 +25,6 @@
},
"devDependencies": {
"slate": "^0.63.0",
- "slate-history": "^0.62.0",
"slate-hyperscript": "^0.62.0"
},
"peerDependencies": {
diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx
index 6ffa5833e..80280987a 100644
--- a/packages/slate-react/src/components/editable.tsx
+++ b/packages/slate-react/src/components/editable.tsx
@@ -10,7 +10,6 @@ import {
Path,
} from 'slate'
import getDirection from 'direction'
-import { HistoryEditor } from 'slate-history'
import throttle from 'lodash/throttle'
import scrollIntoView from 'scroll-into-view-if-needed'
@@ -865,9 +864,10 @@ export const Editable = (props: EditableProps) => {
// hotkeys ourselves. (2019/11/06)
if (Hotkeys.isRedo(nativeEvent)) {
event.preventDefault()
+ const maybeHistoryEditor: any = editor
- if (HistoryEditor.isHistoryEditor(editor)) {
- editor.redo()
+ if (typeof maybeHistoryEditor.redo === 'function') {
+ maybeHistoryEditor.redo()
}
return
@@ -875,9 +875,10 @@ export const Editable = (props: EditableProps) => {
if (Hotkeys.isUndo(nativeEvent)) {
event.preventDefault()
+ const maybeHistoryEditor: any = editor
- if (HistoryEditor.isHistoryEditor(editor)) {
- editor.undo()
+ if (typeof maybeHistoryEditor.undo === 'function') {
+ maybeHistoryEditor.undo()
}
return