From 4bd15ed3950e3a0871f5d0ecb391bb637c05e59d Mon Sep 17 00:00:00 2001 From: Joseph Rollins Date: Wed, 28 Jun 2023 08:29:43 -0700 Subject: [PATCH] Revert to prev behavior on Android to fix caret (#5470) * Revert to prev behavior on Android to fix caret * add changeset --- .changeset/ten-dryers-marry.md | 5 +++++ packages/slate-react/src/components/editable.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/ten-dryers-marry.md diff --git a/.changeset/ten-dryers-marry.md b/.changeset/ten-dryers-marry.md new file mode 100644 index 000000000..bbae333ae --- /dev/null +++ b/.changeset/ten-dryers-marry.md @@ -0,0 +1,5 @@ +--- +'slate-react': patch +--- + +Fix Android caret placement regression when inputting into empty editor diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx index 252bf94f0..7eb1b4f72 100644 --- a/packages/slate-react/src/components/editable.tsx +++ b/packages/slate-react/src/components/editable.tsx @@ -366,7 +366,7 @@ export const Editable = (props: EditableProps) => { selection && ReactEditor.toDOMRange(editor, selection) if (newDomRange) { - if (ReactEditor.isComposing(editor)) { + if (ReactEditor.isComposing(editor) && !IS_ANDROID) { domSelection.collapseToEnd() } else if (Range.isBackward(selection!)) { domSelection.setBaseAndExtent(