mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-12 10:14:02 +02:00
Code Issues Releases Wiki Activity

Fix performance issue with renderPlaceholder (#5339)

Browse Source
This commit is contained in:
Joe Anderson
2023-03-06 16:38:07 +00:00
committed by GitHub
parent 4ab18e8998
commit 62f8ddd971
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/small-timers-sin.md Normal file
View File

@@ -0,0 +1,5 @@
---
'slate-react': patch
---
Fixes #5335. To prevent performance issues, make sure to wrap custom `renderPlaceholder` values in `useCallback`.

6
packages/slate-react/src/components/editable.tsx
View File

@@ -129,6 +129,10 @@ export type EditableProps = {
*/ */
export const Editable = (props: EditableProps) => { export const Editable = (props: EditableProps) => {
const defaultRenderPlaceholder = useCallback(
(props: RenderPlaceholderProps) => <DefaultPlaceholder {...props} />,
[]
)
const { const {
autoFocus, autoFocus,
decorate = defaultDecorate, decorate = defaultDecorate,
@@ -137,7 +141,7 @@ export const Editable = (props: EditableProps) => {
readOnly = false, readOnly = false,
renderElement, renderElement,
renderLeaf, renderLeaf,
renderPlaceholder = props => <DefaultPlaceholder {...props} />, renderPlaceholder = defaultRenderPlaceholder,
scrollSelectionIntoView = defaultScrollSelectionIntoView, scrollSelectionIntoView = defaultScrollSelectionIntoView,
style: userStyle = {}, style: userStyle = {},
as: Component = 'div', as: Component = 'div',