mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-31 10:51:44 +02:00
Code Issues Releases Wiki Activity

Add warning log when references are different in shouldComponentUpdate(Fix #373)

Browse Source
This commit is contained in:
Samy Pessé
2016-10-27 10:17:08 +02:00
parent e5abd9e0b4
commit 6a5a7f37b2
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/components/node.js
View File

@@ -1,4 +1,5 @@
import Immutable from 'immutable'
import Base64 from '../serializers/base-64' import Base64 from '../serializers/base-64'
import Debug from 'debug' import Debug from 'debug'
import React from 'react' import React from 'react'
@@ -7,6 +8,7 @@ import TYPES from '../constants/types'
import Leaf from './leaf' import Leaf from './leaf'
import Void from './void' import Void from './void'
import scrollTo from '../utils/scroll-to' import scrollTo from '../utils/scroll-to'
import warning from '../utils/warning'
/** /**
* Debug. * Debug.
@@ -97,7 +99,10 @@ class Node extends React.Component {
} }
// If the node has changed, update. // If the node has changed, update.
if (props.node != this.props.node) { if (Immutable.is(props.node, this.props.node)) {
if (props.node != this.props.node) {
warning('Encountered different references for identical node values in "shouldComponentUpdate". Check that you are preserving references')
}
return true return true
} }