fix setMarkByKey by adding tests, closes #319

lib/models/text.js

@@ -287,14 +287,14 @@ class Text extends new Record(DEFAULTS) {
    */
 
   updateMark(index, length, mark, properties) {
+    const m = mark.merge(properties)
     const characters = this.characters.map((char, i) => {
       if (i < index) return char
       if (i >= index + length) return char
       let { marks } = char
-      const j = marks.indexOf(mark)
+      if (!marks.has(mark)) return char
-      let m = marks.get(j)
+      marks = marks.remove(mark)
-      m = m.merge(properties)
+      marks = marks.add(m)
-      marks = marks.set(j, m)
       char = char.merge({ marks })
       return char
     })

lib/transforms/apply-operation.js

@@ -245,6 +245,7 @@ function setMark(state, operation) {
   let { document } = state
   let node = document.assertPath(path)
   node = node.updateMark(offset, length, mark, properties)
+  debugger
   document = document.updateDescendant(node)
   state = state.merge({ document })
   return state

test/transforms/fixtures/by-key/set-mark-by-key/set-data/index.js

@@ -0,0 +1,21 @@
+
+export default function (state) {
+  const { document, selection } = state
+  const first = document.getTexts().first()
+
+  return state
+    .transform()
+    .setMarkByKey(
+      first.key,
+      0,
+      first.length,
+      {
+        type: 'bold',
+        data: { key: true }
+      },
+      {
+        data: { key: false }
+      }
+    )
+    .apply()
+}

test/transforms/fixtures/by-key/set-mark-by-key/set-data/input.yaml

@@ -0,0 +1,12 @@
+
+nodes:
+  - kind: block
+    type: paragraph
+    nodes:
+      - kind: text
+        ranges:
+          - text: word
+            marks:
+              - type: bold
+                data:
+                  key: true

test/transforms/fixtures/by-key/set-mark-by-key/set-data/output.yaml

@@ -0,0 +1,12 @@
+
+nodes:
+  - kind: block
+    type: paragraph
+    nodes:
+      - kind: text
+        ranges:
+          - text: word
+            marks:
+              - type: bold
+                data:
+                  key: false