mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-09-02 11:42:53 +02:00
Code Issues Releases Wiki Activity

fix pointForward and pointBackward (#2053)

Browse Source 
* fix next being undefined in pointForward. Adds a check that next exists

* fix both pointForward and pointBackward

* fix for lint tests
This commit is contained in:
Bryan Haakman
2018-08-09 00:59:10 +02:00
committed by Ian Storm Taylor
parent d4b52e3eb5
commit 7ff7a89ea7
2 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/slate/src/changes/on-selection.js
View File

@@ -662,6 +662,7 @@ function pointBackward(change, point, n = 1) {
const p = selection[point]
const isInVoid = document.hasVoidParent(p.path)
// what is this?
if (!isInVoid && p.offset - n >= 0) {
const range = selection[`move${Point}Backward`](n)
change.select(range)
@@ -674,8 +675,9 @@ function pointBackward(change, point, n = 1) {
const block = document.getClosestBlock(p.path)
const isInBlock = block.hasNode(previous.key)
const isPreviousInVoid = previous && document.hasVoidParent(previous.key)
change.moveToEndOfNode(previous)
change[`move${Point}ToEndOfNode`](previous)
// when is this called?
if (!isInVoid && !isPreviousInVoid && isInBlock) {
const range = change.value.selection[`move${Point}Backward`](n)
change.select(range)
@@ -693,20 +695,22 @@ function pointForward(change, point, n = 1) {
const text = document.getNode(p.path)
const isInVoid = document.hasVoidParent(p.path)
// what is this?
if (!isInVoid && p.offset + n <= text.text.length) {
const range = selection[`move${Point}Forward`](n)
change.select(range)
return
}
const block = document.getClosestBlock(p.path)
const isInBlock = block.hasNode(next.key)
const next = document.getNextText(p.path)
const isNextInVoid = next && document.hasVoidParent(next.key)
if (!next) return
change.moveAnchorToStartOf(next)
const block = document.getClosestBlock(p.path)
const isInBlock = block.hasNode(next.key)
const isNextInVoid = document.hasVoidParent(next.key)
change[`move${Point}ToStartOfNode`](next)
// when is this called?
if (!isInVoid && !isNextInVoid && isInBlock) {
const range = change.value.selection[`move${Point}Forward`](n)
change.select(range)