mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-07-31 20:40:19 +02:00
Code Issues Releases Wiki Activity

fix: cancel debounced listeners in Editable (#5322)

Browse Source 
* fix: cancel debounced listeners in Editable

* fix: add change set
This commit is contained in:
Ed Hager
2023-02-27 18:28:13 -06:00
committed by GitHub
parent 680fa9cd34
commit 836f660054
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/red-hats-guess.md Normal file
View File

@@ -0,0 +1,5 @@
---
'slate-react': patch
---
Add checks to Editable selection change handler to avoid errors

5
packages/slate-react/src/components/editable.tsx
View File

@@ -701,6 +701,9 @@ export const Editable = (props: EditableProps) => {
const callbackRef = useCallback( const callbackRef = useCallback(
node => { node => {
if (node == null) { if (node == null) {
onDOMSelectionChange.cancel()
scheduleOnDOMSelectionChange.cancel()
EDITOR_TO_ELEMENT.delete(editor) EDITOR_TO_ELEMENT.delete(editor)
NODE_TO_ELEMENT.delete(editor) NODE_TO_ELEMENT.delete(editor)
@@ -721,7 +724,7 @@ export const Editable = (props: EditableProps) => {
ref.current = node ref.current = node
}, },
[ref, onDOMBeforeInput] [ref, onDOMBeforeInput, onDOMSelectionChange, scheduleOnDOMSelectionChange]
) )
// Attach a native DOM event handler for `selectionchange`, because React's // Attach a native DOM event handler for `selectionchange`, because React's