1
0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-27 09:04:31 +02:00

Fix Paste without Formatting / Paste and Match Style producing uneditable text nodes. (#3415)

* handle plaintext-only pastes using onPaste handler, regardless of browser

* remove extra console.log; merge code paths in onPaste - they contain the same code
This commit is contained in:
Marcin Grzywaczewski
2020-02-22 16:57:50 +01:00
committed by GitHub
parent c5249c745c
commit 83b1319c63
2 changed files with 17 additions and 1 deletions

View File

@@ -26,6 +26,7 @@ import {
isDOMNode, isDOMNode,
isDOMText, isDOMText,
DOMStaticRange, DOMStaticRange,
isPlainTextOnlyPaste,
} from '../utils/dom' } from '../utils/dom'
import { import {
EDITOR_TO_ELEMENT, EDITOR_TO_ELEMENT,
@@ -888,8 +889,11 @@ export const Editable = (props: EditableProps) => {
(event: React.ClipboardEvent<HTMLDivElement>) => { (event: React.ClipboardEvent<HTMLDivElement>) => {
// COMPAT: Firefox doesn't support the `beforeinput` event, so we // COMPAT: Firefox doesn't support the `beforeinput` event, so we
// fall back to React's `onPaste` here instead. // fall back to React's `onPaste` here instead.
// COMPAT: Firefox, Chrome and Safari are not emitting `beforeinput` events
// when "paste without formatting" option is used.
// This unfortunately needs to be handled with paste events instead.
if ( if (
IS_FIREFOX && (IS_FIREFOX || isPlainTextOnlyPaste(event.nativeEvent)) &&
!readOnly && !readOnly &&
hasEditableTarget(editor, event.target) && hasEditableTarget(editor, event.target) &&
!isEventHandled(event, attributes.onPaste) !isEventHandled(event, attributes.onPaste)

View File

@@ -56,6 +56,18 @@ export const isDOMText = (value: any): value is DOMText => {
return isDOMNode(value) && value.nodeType === 3 return isDOMNode(value) && value.nodeType === 3
} }
/**
* Checks whether a paste event is a plaintext-only event.
*/
export const isPlainTextOnlyPaste = (event: ClipboardEvent) => {
return (
event.clipboardData &&
event.clipboardData.getData('text/plain') !== '' &&
event.clipboardData.types.length === 1
)
}
/** /**
* Normalize a DOM point so that it always refers to a text node. * Normalize a DOM point so that it always refers to a text node.
*/ */