From 85b4f2f495b510f8fd8871ba1b8a7998e4237434 Mon Sep 17 00:00:00 2001 From: Nicholas Date: Fri, 2 Feb 2018 11:22:08 +0800 Subject: [PATCH] Docs: Add that Edge does not support `CTRL+...` (#1585) The CTRL-` example fails in Edge due to lack of support for CTRL+... events. Reference: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/742263/. Added a note so other Edge users won't be tripped up by the walkthrough. --- docs/walkthroughs/defining-custom-block-nodes.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/walkthroughs/defining-custom-block-nodes.md b/docs/walkthroughs/defining-custom-block-nodes.md index 54a84f982..f4800d715 100644 --- a/docs/walkthroughs/defining-custom-block-nodes.md +++ b/docs/walkthroughs/defining-custom-block-nodes.md @@ -158,6 +158,8 @@ class App extends React.Component { Now, if you press `control-\`` the block your cursor is in should turn into a code block! Magic! +*Note: The Edge browser does not currently support `control-...` key events (see [issue](https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/742263/)), so this example won't work on it.* + But we forgot one thing. When you hit `control-\`` again, it should change the code block back into a paragraph. To do that, we'll need to add a bit of logic to change the type we set based on whether any of the currently selected blocks are already a code block: ```js