From 8a2368f851c701095673fc5eebbe337caf10573a Mon Sep 17 00:00:00 2001 From: Ian Storm Taylor Date: Thu, 10 May 2018 19:25:18 -0700 Subject: [PATCH] update pull request template --- .github/ISSUE_TEMPLATE.md | 6 +++--- .github/PULL_REQUEST_TEMPLATE.md | 21 +++++++++++++-------- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 5b837095b..4427af19b 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -11,9 +11,9 @@ https://slate-slack.herokuapp.com/ @@ -24,13 +24,18 @@ If you don't include one of these, there's a very good chance your pull request If your change is non-trivial, please include a short description of how the new logic works, and why you decided to solve it the way you did. This is incredibly helpful so that reviewers don't have to guess based on the code. --> -#### Checklist +#### Have you checked that...? - + -* [ ] Tests passed (`yarn run test`) -* [ ] Linting passed (`yarn run lint`). To automatically fix potential errors, try `yarn run prettier`. +* [ ] The new code matches the existing patterns and styles. +* [ ] The tests pass with `yarn test`. +* [ ] The linter passes with `yarn lint`. (Fix errors with `yarn prettier`.) +* [ ] The relevant examples still work. (Run examples with `yarn watch`.) + +### Does this fix any issues or need any specific reviewers? Fixes: # - Reviewers: @