mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-19 05:31:56 +02:00
Code Issues Releases Wiki Activity

fix: default scroll selection (#4652)

Browse Source 
* fix: default scroll selection

* feat: use Range.isCollapsed to check the selection

* chore: add changeset

* fix: grammer correction

* fix: grammer correction
This commit is contained in:
Karthikeyan
2021-11-16 14:51:14 +05:30
committed by GitHub
parent 7d9d25e179
commit 95389ed7b0
2 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/green-penguins-check.md Normal file
View File

@@ -0,0 +1,5 @@
---
'slate-react': patch
---
Disabled the auto scroll behaviour when the editor has any active selection

19
packages/slate-react/src/components/editable.tsx
View File

@@ -1328,12 +1328,19 @@ const defaultScrollSelectionIntoView = (
editor: ReactEditor, editor: ReactEditor,
domRange: DOMRange domRange: DOMRange
) => { ) => {
const leafEl = domRange.startContainer.parentElement! // This was affecting the selection of multiple blocks and dragging behavior,
leafEl.getBoundingClientRect = domRange.getBoundingClientRect.bind(domRange) // so enabled only if the selection has been collapsed.
scrollIntoView(leafEl, { if (
scrollMode: 'if-needed', !editor.selection ||
}) (editor.selection && Range.isCollapsed(editor.selection))
delete leafEl.getBoundingClientRect ) {
const leafEl = domRange.startContainer.parentElement!
leafEl.getBoundingClientRect = domRange.getBoundingClientRect.bind(domRange)
scrollIntoView(leafEl, {
scrollMode: 'if-needed',
})
delete leafEl.getBoundingClientRect
}
} }
/** /**