From 990d37b694eeb5d6aa488b8d78f49b306d18701c Mon Sep 17 00:00:00 2001 From: Gersom van Ginkel Date: Wed, 7 Nov 2018 20:34:15 +0100 Subject: [PATCH] Avoid async commands causing rerenders after unmount. (#2395) * When the component unmounts, make sure async commands don't trigger react updates. * Eslint fix --- packages/slate-react/src/components/editor.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/slate-react/src/components/editor.js b/packages/slate-react/src/components/editor.js index 2e2aea6ce..c03901ba2 100644 --- a/packages/slate-react/src/components/editor.js +++ b/packages/slate-react/src/components/editor.js @@ -122,6 +122,14 @@ class Editor extends React.Component { } } + /** + * When the component unmounts, make sure async commands don't trigger react updates. + */ + + componentWillUnmount() { + this.tmp.mounted = false + } + /** * Render the editor. *