mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-12 10:14:02 +02:00
Code Issues Releases Wiki Activity

Prevent native insert at the end of anchors (#4948)

Browse Source 
* Prevent native insert at the end of anchors

* add changeset
This commit is contained in:
Eric Meier
2022-04-18 12:39:45 -04:00
committed by GitHub
parent 5160efeea4
commit 9957c21435
2 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/poor-mangos-burn.md Normal file
View File

@@ -0,0 +1,5 @@
---
'slate-react': patch
---
Prevent native insert at the end of anchor elements

23
packages/slate-react/src/components/editable.tsx
View File

@@ -368,19 +368,20 @@ export const Editable = (props: EditableProps) => {
native = false
}
// Chrome also has issues correctly editing the end of nodes: https://bugs.chromium.org/p/chromium/issues/detail?id=1259100
// Therefore we don't allow native events to insert text at the end of nodes.
// Chrome also has issues correctly editing the end of anchor elements: https://bugs.chromium.org/p/chromium/issues/detail?id=1259100
// Therefore we don't allow native events to insert text at the end of anchor nodes.
const { anchor } = selection
const inline = Editor.above(editor, {
at: anchor,
match: n => Editor.isInline(editor, n),
mode: 'highest',
})
if (inline) {
const [, inlinePath] = inline
if (Editor.isEnd(editor, anchor, anchor.path)) {
const [node] = ReactEditor.toDOMPoint(editor, selection.anchor)
const anchorNode = node.parentElement?.closest('a')
if (Editor.isEnd(editor, selection.anchor, inlinePath)) {
native = false
if (anchorNode && ReactEditor.hasDOMNode(editor, anchorNode)) {
const node = ReactEditor.toSlateNode(editor, anchorNode)
const path = ReactEditor.findPath(editor, node)
if (Editor.isEnd(editor, anchor, path)) {
native = false
}
}
}
}