mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-14 03:03:58 +02:00
Code Issues Releases Wiki Activity

Hanging Selection paste in insertFragmentAtRange (#1742)

Browse Source
This commit is contained in:
Jinxuan Zhu
2018-04-27 17:02:56 -04:00
committed by Ian Storm Taylor
parent 2dd77c00f1
commit 9b39a89f20
2 changed files with 49 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/slate/src/changes/at-range.js
View File

@@ -671,7 +671,11 @@ Changes.insertFragmentAtRange = (change, range, fragment, options = {}) => {
// If the range is expanded, delete it first. // If the range is expanded, delete it first.
if (range.isExpanded) { if (range.isExpanded) {
change.deleteAtRange(range, { normalize: false }) change.deleteAtRange(range, { normalize: false })
range = range.collapseToStart() if (change.value.document.getDescendant(range.startKey)) {
range = range.collapseToStart()
} else {
range = range.collapseTo(range.endKey, 0)
}
} }
// If the fragment is empty, there's nothing to do after deleting. // If the fragment is empty, there's nothing to do after deleting.

44
packages/slate/test/changes/at-current-range/insert-fragment/hanging-selection-single-block.js Normal file
View File

@@ -0,0 +1,44 @@
/** @jsx h */
import h from '../../../helpers/h'
const fragment = (
<document>
<paragraph>fragment zero</paragraph>
<paragraph>fragment one</paragraph>
<paragraph>fragment two</paragraph>
</document>
)
export default function(change) {
change.insertFragment(fragment)
}
export const input = (
<value>
<document>
<paragraph>zero</paragraph>
<paragraph>
<anchor />one
</paragraph>
<quote>
<focus />two
</quote>
</document>
</value>
)
// The cursor position of insertFragment has some problems;
// If you submit PR to fixed cursor position restore in insertFragment;
// Please change this test as well
export const output = (
<value>
<document>
<paragraph>zero</paragraph>
<quote>fragment zero</quote>
<paragraph>fragment one</paragraph>
<paragraph>
<cursor />fragment twotwo
</paragraph>
</document>
</value>
)