Fix bug where insertBlock and insertBlockAtRange always inserted the block below the target, even though focus was collapsed to start (#1037)

src/transforms/at-range.js

@@ -597,7 +597,11 @@ Transforms.insertBlockAtRange = (transform, range, block, options = {}) => {
   const index = parent.nodes.indexOf(startBlock)
 
   if (startBlock.isVoid) {
-    transform.insertNodeByKey(parent.key, index + 1, block, { normalize })
+    let beforeOrAfterIndex = index
+    if (range.isAtEndOf(startBlock)) {
+      beforeOrAfterIndex++
+    }
+    transform.insertNodeByKey(parent.key, beforeOrAfterIndex, block, { normalize })
   }
 
   else if (startBlock.isEmpty) {

test/transforms/fixtures/at-current-range/insert-block/is-void/index.js

@@ -15,10 +15,10 @@ export default function (state) {
   const next = state
     .transform()
     .select(range)
-    .insertBlock('image')
+    .insertBlock('video')
     .apply()
 
-  const updated = next.document.getTexts().last()
+  const updated = next.document.getTexts().first()
 
   assert.deepEqual(
     next.selection.toJS(),

test/transforms/fixtures/at-current-range/insert-block/is-void/input.yaml

@@ -6,3 +6,8 @@ nodes:
     nodes:
       - kind: text
         text: ""
+  - kind: block
+    type: paragraph
+    nodes:
+      - kind: text
+        text: "Some text"

test/transforms/fixtures/at-current-range/insert-block/is-void/output.yaml

@@ -1,10 +1,15 @@
 
 nodes:
   - kind: block
-    type: image
+    type: video
-    isVoid: true
-  - kind: block
-    type: image
     nodes:
       - kind: text
         text: ""
+  - kind: block
+    isVoid: true
+    type: image
+  - kind: block
+    type: paragraph
+    nodes:
+      - kind: text
+        text: "Some text"

test/transforms/fixtures/at-range/insert-block-at-range/is-void-focus-end/index.js

@@ -0,0 +1,17 @@
+
+export default function (state) {
+  const { document, selection } = state
+  const texts = document.getTexts()
+  const first = texts.first()
+  const range = selection.merge({
+    anchorKey: first.key,
+    anchorOffset: 1,
+    focusKey: first.key,
+    focusOffset: 1
+  })
+
+  return state
+    .transform()
+    .insertBlockAtRange(range, 'image')
+    .apply()
+}

test/transforms/fixtures/at-range/insert-block-at-range/is-void-focus-end/input.yaml

@@ -0,0 +1,5 @@
+
+nodes:
+  - kind: block
+    type: video
+    isVoid: true

test/transforms/fixtures/at-range/insert-block-at-range/is-void-focus-end/output.yaml

@@ -1,7 +1,7 @@
 
 nodes:
   - kind: block
-    type: image
+    type: video
     isVoid: true
   - kind: block
     type: image

test/transforms/fixtures/at-range/insert-block-at-range/is-void-focus-start/input.yaml

@@ -0,0 +1,5 @@
+
+nodes:
+  - kind: block
+    type: video
+    isVoid: true

test/transforms/fixtures/at-range/insert-block-at-range/is-void-focus-start/output.yaml

@@ -2,7 +2,9 @@
 nodes:
   - kind: block
     type: image
-    isVoid: true
     nodes:
       - kind: text
         text: ""
+  - kind: block
+    type: video
+    isVoid: true