mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-14 03:03:58 +02:00
Code Issues Releases Wiki Activity

Fix deletion of selected inline void nodes in Safari (#4331)

Browse Source 
Co-authored-by: Claudéric Demers <clauderic.d@gmail.com>
This commit is contained in:
Szymon Wiszczuk
2021-06-09 17:54:41 +02:00
committed by GitHub
parent 6c993523ca
commit a3bc97af3e
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/safari-delete-inlinevoid.md Normal file
View File

@@ -0,0 +1,5 @@
---
'slate-react': patch
---
Fix deletion of selected inline void nodes in Safari when presssing `backspace` or `delete`. This is a bug that [was originally fixed only for Google Chrome](https://github.com/ianstormtaylor/slate/issues/3456), but the fix also needs to be applied in Safari.

4
packages/slate-react/src/components/editable.tsx
View File

@@ -1066,8 +1066,8 @@ export const Editable = (props: EditableProps) => {
return return
} }
} else { } else {
if (IS_CHROME) { if (IS_CHROME || IS_SAFARI) {
// COMPAT: Chrome supports `beforeinput` event but does not fire // COMPAT: Chrome and Safari support `beforeinput` event but do not fire
// an event when deleting backwards in a selected void inline node // an event when deleting backwards in a selected void inline node
if ( if (
selection && selection &&