Insert outside inline when selection is at the end (#3260)

* Insert outside inline when selection is at the end

* Move inline edge check to insert_text

* Fix selection point after deleting text

packages/slate/src/create-editor.ts

@@ -128,7 +128,26 @@ export const createEditor = (): Editor => {
           }
 
           case 'insert_text': {
-            Editor.insertText(editor, command.text)
+            if (selection) {
+              const { anchor } = selection
+
+              // If the cursor is at the end of an inline, move it outside
+              // of the inline before inserting
+              if (Range.isCollapsed(selection)) {
+                const inline = Editor.match(editor, anchor, 'inline')
+
+                if (inline) {
+                  const [, inlinePath] = inline
+
+                  if (Editor.isEnd(editor, anchor, inlinePath)) {
+                    const point = Editor.after(editor, inlinePath)!
+                    Editor.setSelection(editor, { anchor: point, focus: point })
+                  }
+                }
+              }
+
+              Editor.insertText(editor, command.text)
+            }
             break
           }
         }

packages/slate/src/interfaces/editor/transforms/text.ts

@@ -392,6 +392,7 @@ export const TextTransforms = {
           const pointRef = Editor.pointRef(editor, end)
           Editor.delete(editor, { at, voids })
           at = pointRef.unref()!
+          Editor.setSelection(editor, { anchor: at, focus: at })
         }
       }
 

packages/slate/test/transforms/insertText/selection/inline-end.js

@@ -0,0 +1,31 @@
+/** @jsx jsx */
+
+import { jsx } from '../../..'
+
+export const run = editor => {
+  editor.exec({ type: 'insert_text', text: 'four' })
+}
+
+export const input = (
+  <editor>
+    <block>
+      one
+      <inline>
+        two
+        <cursor />
+      </inline>
+      three
+    </block>
+  </editor>
+)
+
+export const output = (
+  <editor>
+    <block>
+      one
+      <inline>two</inline>
+      fourthree
+      <cursor />
+    </block>
+  </editor>
+)