mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-13 10:44:02 +02:00
Code Issues Releases Wiki Activity

fix: Add missing dependencies to useEffect and React.memo calls (#5289) (#5310)

Browse Source 
* fix: Add missing dependencies to useEffect and React.memo calls (#5289)

* Add changeset
This commit is contained in:
Bob Ippolito
2023-02-23 12:22:52 -08:00
committed by GitHub
parent 942fbd7ceb
commit b94254d694
4 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/pretty-buses-stare.md Normal file
View File

@@ -0,0 +1,5 @@
---
'slate-react': patch
---
Fix to ensure that the latest versions of onChange and renderPlaceholder are used

1
packages/slate-react/src/components/element.tsx
View File

@@ -139,6 +139,7 @@ const MemoizedElement = React.memo(Element, (prev, next) => {
prev.element === next.element && prev.element === next.element &&
prev.renderElement === next.renderElement && prev.renderElement === next.renderElement &&
prev.renderLeaf === next.renderLeaf && prev.renderLeaf === next.renderLeaf &&
prev.renderPlaceholder === next.renderPlaceholder &&
isElementDecorationsEqual(prev.decorations, next.decorations) && isElementDecorationsEqual(prev.decorations, next.decorations) &&
(prev.selection === next.selection || (prev.selection === next.selection ||
(!!prev.selection && (!!prev.selection &&

2
packages/slate-react/src/components/slate.tsx
View File

@@ -68,7 +68,7 @@ export const Slate = (props: {
EDITOR_TO_ON_CHANGE.set(editor, () => {}) EDITOR_TO_ON_CHANGE.set(editor, () => {})
unmountRef.current = true unmountRef.current = true
} }
}, []) }, [onContextChange])
const [isFocused, setIsFocused] = useState(ReactEditor.isFocused(editor)) const [isFocused, setIsFocused] = useState(ReactEditor.isFocused(editor))

1
packages/slate-react/src/components/text.tsx
View File

@@ -84,6 +84,7 @@ const MemoizedText = React.memo(Text, (prev, next) => {
next.parent === prev.parent && next.parent === prev.parent &&
next.isLast === prev.isLast && next.isLast === prev.isLast &&
next.renderLeaf === prev.renderLeaf && next.renderLeaf === prev.renderLeaf &&
next.renderPlaceholder === prev.renderPlaceholder &&
next.text === prev.text && next.text === prev.text &&
isTextDecorationsEqual(next.decorations, prev.decorations) isTextDecorationsEqual(next.decorations, prev.decorations)
) )