mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-26 16:44:22 +02:00
Code Issues Releases Wiki Activity

Clear scroll timer when component unmount (#867)

Browse Source
This commit is contained in:
pa-nam
2017-06-11 00:41:27 +07:00
committed by Ian Storm Taylor
parent 57da8da4b4
commit b967cf7c79
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/components/node.js
View File

@@ -161,6 +161,17 @@ class Node extends React.Component {
if (this.props.node != prevProps.node) this.updateScroll() if (this.props.node != prevProps.node) this.updateScroll()
} }
/**
* There is a corner case, that some nodes are unmounted right after they update
* Then, when the timer execute, it will throw the error
* `findDOMNode was called on an unmounted component`
* We should clear the timer from updateScroll here
*/
componentWillUnmount = () => {
clearTimeout(this.scrollTimer)
}
/** /**
* Update the scroll position after a change as occured if this is a leaf * Update the scroll position after a change as occured if this is a leaf
* block and it has the selection's ending edge. This ensures that scrolling * block and it has the selection's ending edge. This ensures that scrolling
@@ -182,7 +193,7 @@ class Node extends React.Component {
// The native selection will be updated after componentDidMount or componentDidUpdate. // The native selection will be updated after componentDidMount or componentDidUpdate.
// Use setTimeout to queue scrolling to the last when the native selection has been updated to the correct value. // Use setTimeout to queue scrolling to the last when the native selection has been updated to the correct value.
setTimeout(() => { this.scrollTimer = setTimeout(() => {
const el = ReactDOM.findDOMNode(this) const el = ReactDOM.findDOMNode(this)
const window = getWindow(el) const window = getWindow(el)
const native = window.getSelection() const native = window.getSelection()