From b973580c54be4cfddd3e7b61e6c7f4222d6ee5b2 Mon Sep 17 00:00:00 2001 From: Robert Dale Smith Date: Mon, 13 Nov 2017 13:49:26 -0600 Subject: [PATCH] corrects overscroll issue inside scrollable containers (#1032) (#1383) * corrects overscroll issue inside scrollable containers; another fix for #1032 * fix(#1032) - set scrollers offset if within scrollable container --- packages/slate-react/src/utils/scroll-to-selection.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/slate-react/src/utils/scroll-to-selection.js b/packages/slate-react/src/utils/scroll-to-selection.js index 49c7fce15..44c0f24f7 100644 --- a/packages/slate-react/src/utils/scroll-to-selection.js +++ b/packages/slate-react/src/utils/scroll-to-selection.js @@ -71,10 +71,11 @@ function scrollToSelection(selection) { xOffset = pageXOffset } else { const { offsetWidth, offsetHeight, scrollTop, scrollLeft } = scroller + const scrollerRect = scroller.getBoundingClientRect() width = offsetWidth height = offsetHeight - yOffset = scrollTop - xOffset = scrollLeft + yOffset = scrollTop - scrollerRect.top + xOffset = scrollLeft - scrollerRect.left } const top = (backward ? rect.top : rect.bottom) + yOffset