mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-21 14:41:23 +02:00
Code Issues Releases Wiki Activity

Use lodash throttle instead of debounce for updating selection change (#3355)

Browse Source 
* Add lodash

* Switched debounce to lodash/throttle

* Updated yarn.lock
This commit is contained in:
Sunny Hirai
2020-02-22 09:08:22 -08:00
committed by GitHub
parent 1f11276ebd
commit bd52b9d080
3 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/slate-react/package.json
View File

@@ -14,12 +14,12 @@
"dist/" "dist/"
], ],
"dependencies": { "dependencies": {
"@types/debounce": "^1.2.0",
"@types/is-hotkey": "^0.1.1", "@types/is-hotkey": "^0.1.1",
"debounce": "^1.2.0", "@types/lodash": "^4.14.149",
"direction": "^1.0.3", "direction": "^1.0.3",
"is-hotkey": "^0.1.6", "is-hotkey": "^0.1.6",
"is-plain-object": "^3.0.0", "is-plain-object": "^3.0.0",
"lodash": "^4.17.4",
"scroll-into-view-if-needed": "^2.2.20" "scroll-into-view-if-needed": "^2.2.20"
}, },
"devDependencies": { "devDependencies": {

4
packages/slate-react/src/components/editable.tsx
View File

@@ -8,7 +8,7 @@ import {
Text, Text,
Transforms, Transforms,
} from 'slate' } from 'slate'
import debounce from 'debounce' import throttle from 'lodash/throttle'
import scrollIntoView from 'scroll-into-view-if-needed' import scrollIntoView from 'scroll-into-view-if-needed'
import Children from './children' import Children from './children'
@@ -348,7 +348,7 @@ export const Editable = (props: EditableProps) => {
// released. This causes issues in situations where another change happens // released. This causes issues in situations where another change happens
// while a selection is being dragged. // while a selection is being dragged.
const onDOMSelectionChange = useCallback( const onDOMSelectionChange = useCallback(
debounce(() => { throttle(() => {
if (!readOnly && !state.isComposing && !state.isUpdatingSelection) { if (!readOnly && !state.isComposing && !state.isUpdatingSelection) {
const { activeElement } = window.document const { activeElement } = window.document
const el = ReactEditor.toDOMNode(editor, editor) const el = ReactEditor.toDOMNode(editor, editor)

10
yarn.lock
View File

@@ -2472,11 +2472,6 @@
dependencies: dependencies:
"@types/node" ">= 8" "@types/node" ">= 8"
"@types/debounce@^1.2.0":
version "1.2.0"
resolved "https://registry.yarnpkg.com/@types/debounce/-/debounce-1.2.0.tgz#9ee99259f41018c640b3929e1bb32c3dcecdb192"
integrity sha512-bWG5wapaWgbss9E238T0R6bfo5Fh3OkeoSt245CM7JJwVwpw6MEBCbIxLq5z8KzsE3uJhzcIuQkyiZmzV3M/Dw==
"@types/eslint-visitor-keys@^1.0.0": "@types/eslint-visitor-keys@^1.0.0":
version "1.0.0" version "1.0.0"
resolved "https://registry.yarnpkg.com/@types/eslint-visitor-keys/-/eslint-visitor-keys-1.0.0.tgz#1ee30d79544ca84d68d4b3cdb0af4f205663dd2d" resolved "https://registry.yarnpkg.com/@types/eslint-visitor-keys/-/eslint-visitor-keys-1.0.0.tgz#1ee30d79544ca84d68d4b3cdb0af4f205663dd2d"
@@ -4259,11 +4254,6 @@ dateformat@^3.0.0:
resolved "https://registry.yarnpkg.com/dateformat/-/dateformat-3.0.3.tgz#a6e37499a4d9a9cf85ef5872044d62901c9889ae" resolved "https://registry.yarnpkg.com/dateformat/-/dateformat-3.0.3.tgz#a6e37499a4d9a9cf85ef5872044d62901c9889ae"
integrity sha512-jyCETtSl3VMZMWeRo7iY1FL19ges1t55hMo5yaam4Jrsm5EPL89UQkoQRyiI+Yf4k8r2ZpdngkV8hr1lIdjb3Q== integrity sha512-jyCETtSl3VMZMWeRo7iY1FL19ges1t55hMo5yaam4Jrsm5EPL89UQkoQRyiI+Yf4k8r2ZpdngkV8hr1lIdjb3Q==
debounce@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/debounce/-/debounce-1.2.0.tgz#44a540abc0ea9943018dc0eaa95cce87f65cd131"
integrity sha512-mYtLl1xfZLi1m4RtQYlZgJUNQjl4ZxVnHzIR8nLLgi4q1YT8o/WM+MK/f8yfcc9s5Ir5zRaPZyZU6xs1Syoocg==
debug@2.6.9, debug@^2.2.0, debug@^2.3.3, debug@^2.6.8, debug@^2.6.9: debug@2.6.9, debug@^2.2.0, debug@^2.3.3, debug@^2.6.8, debug@^2.6.9:
version "2.6.9" version "2.6.9"
resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.9.tgz#5d128515df134ff327e90a4c93f4e077a536341f" resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.9.tgz#5d128515df134ff327e90a4c93f4e077a536341f"