From bff3d34a2d1d5fc80c46ba6dd870e971adb99550 Mon Sep 17 00:00:00 2001
From: Stan Chang Khin Boon <khinboon@gmail.com>
Date: Fri, 23 Mar 2018 05:22:57 +0800
Subject: [PATCH] Don't stop propagation of drop event (#1716)

Summary:

We mirrored the fix in PR #1278 (meant for #1277) but for drop event.
This fixed an issue I faced with Slate swallowing drop event, kind of breaking compatibility with react-dnd.

/cc @AlbertHilb
---
 packages/slate-react/src/components/content.js | 5 +++--
 packages/slate-react/src/plugins/before.js     | 3 ---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/packages/slate-react/src/components/content.js b/packages/slate-react/src/components/content.js
index 72024ed6d..549811a26 100644
--- a/packages/slate-react/src/components/content.js
+++ b/packages/slate-react/src/components/content.js
@@ -317,14 +317,15 @@ class Content extends React.Component {
       }
     }
 
-    // Don't handle drag events coming from embedded editors.
+    // Don't handle drag and drop events coming from embedded editors.
     if (
       handler == 'onDragEnd' ||
       handler == 'onDragEnter' ||
       handler == 'onDragExit' ||
       handler == 'onDragLeave' ||
       handler == 'onDragOver' ||
-      handler == 'onDragStart'
+      handler == 'onDragStart' ||
+      handler == 'onDrop'
     ) {
       const { target } = event
       const targetEditorNode = target.closest('[data-slate-editor]')
diff --git a/packages/slate-react/src/plugins/before.js b/packages/slate-react/src/plugins/before.js
index 8185538f2..e746abe50 100644
--- a/packages/slate-react/src/plugins/before.js
+++ b/packages/slate-react/src/plugins/before.js
@@ -301,9 +301,6 @@ function BeforePlugin() {
    */
 
   function onDrop(event, change, editor) {
-    // Stop propagation so the event isn't visible to parent editors.
-    event.stopPropagation()
-
     // Nothing happens in read-only mode.
     if (editor.props.readOnly) return true