From c020ca23b6f5d2307eb62630566ec711def89fcf Mon Sep 17 00:00:00 2001 From: Alex <32290337+ahoisl@users.noreply.github.com> Date: Sat, 4 Dec 2021 17:08:48 +0100 Subject: [PATCH] Fix onDragStart callback dependency on 'readonly' (#4707) * fix: add 'readonly' dependency for onDragStart callback * add changeset --- .changeset/hungry-dingos-do.md | 5 +++++ packages/slate-react/src/components/editable.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/hungry-dingos-do.md diff --git a/.changeset/hungry-dingos-do.md b/.changeset/hungry-dingos-do.md new file mode 100644 index 000000000..8974336b0 --- /dev/null +++ b/.changeset/hungry-dingos-do.md @@ -0,0 +1,5 @@ +--- +'slate-react': patch +--- + +fix: add 'readonly' dependency for onDragStart callback diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx index ac99add80..22024bd76 100644 --- a/packages/slate-react/src/components/editable.tsx +++ b/packages/slate-react/src/components/editable.tsx @@ -936,7 +936,7 @@ export const Editable = (props: EditableProps) => { ReactEditor.setFragmentData(editor, event.dataTransfer) } }, - [attributes.onDragStart] + [readOnly, attributes.onDragStart] )} onDrop={useCallback( (event: React.DragEvent) => {