mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-17 12:41:44 +02:00
Code Issues Releases Wiki Activity

Prevent crash when handling composition of 2+ keypresses when selection is not collapsed (#2218)

Browse Source 
https://github.com/ianstormtaylor/slate/issues/1879
When composition starts and the current selection is not collapsed, the
second composition key-down would drop the text wrapping <spans> which
resulted on crash in content.updateSelection after composition ends
(because it cannot find <span> nodes in DOM). This is a workaround that
erases selection as soon as composition starts and preventing <spans>
to be dropped.
This commit is contained in:
Kaspars Dancis
2018-10-25 10:47:29 -06:00
committed by Ian Storm Taylor
parent abc75bb45e
commit d5834bb5b0
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/slate-react/src/plugins/before.js
View File

@@ -167,6 +167,20 @@ function BeforePlugin() {
editor.setState({ isComposing: true }) editor.setState({ isComposing: true })
} }
const { value } = change
const { selection } = value
if (!selection.isCollapsed) {
// https://github.com/ianstormtaylor/slate/issues/1879
// When composition starts and the current selection is not collapsed, the
// second composition key-down would drop the text wrapping <spans> which
// resulted on crash in content.updateSelection after composition ends
// (because it cannot find <span> nodes in DOM). This is a workaround that
// erases selection as soon as composition starts and preventing <spans>
// to be dropped.
change.delete()
}
debug('onCompositionStart', { event }) debug('onCompositionStart', { event })
next() next()
} }