mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-20 22:21:20 +02:00
Code Issues Releases Wiki Activity

fix isDraggingInternally reset logic (#4828)

Browse Source
This commit is contained in:
Eric Meier
2022-02-11 05:00:17 +01:00
committed by GitHub
parent 80661509ec
commit d5ac82373b
2 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/slate-react/src/components/editable.tsx
View File

@@ -970,8 +970,6 @@ export const Editable = (props: EditableProps) => {
at: draggedRange,
})
}
state.isDraggingInternally = false
}
ReactEditor.insertData(editor, data)
@@ -982,22 +980,26 @@ export const Editable = (props: EditableProps) => {
ReactEditor.focus(editor)
}
}
state.isDraggingInternally = false
},
[readOnly, attributes.onDrop]
)}
onDragEnd={useCallback(
(event: React.DragEvent<HTMLDivElement>) => {
// When dropping on a different droppable element than the current editor,
// `onDrop` is not called. So we need to clean up in `onDragEnd` instead.
// Note: `onDragEnd` is only called when `onDrop` is not called
if (
!readOnly &&
state.isDraggingInternally &&
hasTarget(editor, event.target) &&
!isEventHandled(event, attributes.onDragEnd)
attributes.onDragEnd &&
hasTarget(editor, event.target)
) {
state.isDraggingInternally = false
attributes.onDragEnd(event)
}
// When dropping on a different droppable element than the current editor,
// `onDrop` is not called. So we need to clean up in `onDragEnd` instead.
// Note: `onDragEnd` is only called when `onDrop` is not called
state.isDraggingInternally = false
},
[readOnly, attributes.onDragEnd]
)}