mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-13 18:53:59 +02:00
Code Issues Releases Wiki Activity

Fix selection getting incorrectly set in readonly shadow dom case (#5259)

Browse Source 
* Fix selection getting incorrectly set in readonly shadow dom case

* Add changeset for slate react
This commit is contained in:
Jaclyn Feminella
2023-01-14 08:00:38 -05:00
committed by GitHub
parent 0df29a9dd7
commit d7de564d62
3 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/fast-apricots-deliver.md Normal file
View File

@@ -0,0 +1,5 @@
---
'slate-react': patch
---
Updates the selection correctly in readonly shadowdom

2
packages/slate-react/src/plugin/react-editor.ts
View File

@@ -726,7 +726,7 @@ export const ReactEditor = {
// `isCollapsed` for a Selection that comes from a ShadowRoot. // `isCollapsed` for a Selection that comes from a ShadowRoot.
// (2020/08/08) // (2020/08/08)
// https://bugs.chromium.org/p/chromium/issues/detail?id=447523 // https://bugs.chromium.org/p/chromium/issues/detail?id=447523
if (IS_CHROME && hasShadowRoot()) { if (IS_CHROME && hasShadowRoot(anchorNode)) {
isCollapsed = isCollapsed =
domRange.anchorNode === domRange.focusNode && domRange.anchorNode === domRange.focusNode &&
domRange.anchorOffset === domRange.focusOffset domRange.anchorOffset === domRange.focusOffset

13
packages/slate-react/src/utils/dom.ts
View File

@@ -137,10 +137,15 @@ export const normalizeDOMPoint = (domPoint: DOMPoint): DOMPoint => {
* Determines wether the active element is nested within a shadowRoot * Determines wether the active element is nested within a shadowRoot
*/ */
export const hasShadowRoot = () => { export const hasShadowRoot = (node: Node | null) => {
return !!( let parent = node && node.parentNode
window.document.activeElement && window.document.activeElement.shadowRoot while (parent) {
) if (parent.toString() === '[object ShadowRoot]') {
return true
}
parent = parent.parentNode
}
return false
} }
/** /**