mirror/slate
1
0
Fork 0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-08-14 11:14:04 +02:00
Code Issues Releases Wiki Activity

[hyperscript] rename decorators option in params to decorations (#2074)

Browse Source 
#### Is this adding or improving a _feature_ or fixing a _bug_?

Debt.

#### What's the new behavior?

`createHyperscript` takes an options object that now looks for the `decorations` property instead of the `decorators` property

#### How does this change work?

Pretty straightforward rename of an option, then all of its uses and wherever the term decorators showed up in docs

#### Have you checked that...?

* [x] The new code matches the existing patterns and styles.
* [x] The tests pass with `yarn test`.
* [x] The linter passes with `yarn lint`. (Fix errors with `yarn prettier`.)
* [x] The relevant examples still work. (Run examples with `yarn watch`.)

#### Does this fix any issues or need any specific reviewers?

Fixes: #1996
Reviewers: @ianstormtaylor
This commit is contained in:
David Chang
2018-08-15 12:41:39 -07:00
committed by Ian Storm Taylor
parent acfffe0c2a
commit f37dd21137
15 changed files with 29 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/slate-hyperscript/src/index.js
View File

@@ -445,7 +445,7 @@ function createChildren(children, options = {}) {
*/
function resolveCreators(options) {
const { blocks = {}, inlines = {}, marks = {}, decorators = {} } = options
const { blocks = {}, inlines = {}, marks = {}, decorations = {} } = options
const creators = {
...CREATORS,
@@ -464,8 +464,8 @@ function resolveCreators(options) {
creators[key] = normalizeMark(key, marks[key])
})
Object.keys(decorators).map(key => {
creators[key] = normalizeNode(key, decorators[key], 'decoration')
Object.keys(decorations).map(key => {
creators[key] = normalizeNode(key, decorations[key], 'decoration')
})
return creators