From fbc9838fd72e78bfa9af49013981939773dcca11 Mon Sep 17 00:00:00 2001 From: Brian Bucknam Date: Thu, 17 Nov 2022 09:19:01 -0800 Subject: [PATCH] Add hanging option to unsetNodes (#5189) Since this really just calls setNodes, it seems like it should offer the same options. Without this change, doing something like applying a mark to the contents of a selected block with `hanging` works one way, while trying to do the reverse (remove the mark) cannot include the "hang". --- .changeset/light-moose-jam.md | 5 +++++ docs/api/transforms.md | 2 +- packages/slate/src/transforms/node.ts | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/light-moose-jam.md diff --git a/.changeset/light-moose-jam.md b/.changeset/light-moose-jam.md new file mode 100644 index 000000000..bf104ac06 --- /dev/null +++ b/.changeset/light-moose-jam.md @@ -0,0 +1,5 @@ +--- +'slate': patch +--- + +Add hanging option to unsetNodes so it matches setNodes diff --git a/docs/api/transforms.md b/docs/api/transforms.md index 4182110be..0105c5800 100644 --- a/docs/api/transforms.md +++ b/docs/api/transforms.md @@ -101,7 +101,7 @@ Options supported: `NodeOptions & {hanging?: boolean, split?: boolean}`. For `op Unset properties of nodes at the specified location. If no location is specified, use the selection. -Options supported: `NodeOptions & {split?: boolean}`. For `options.mode`, `'all'` is also supported. +Options supported: `NodeOptions & {hanging?: boolean, split?: boolean}`. For `options.mode`, `'all'` is also supported. #### `Transforms.liftNodes(editor: Editor, options?)` diff --git a/packages/slate/src/transforms/node.ts b/packages/slate/src/transforms/node.ts index bf3a07be6..881c1503e 100644 --- a/packages/slate/src/transforms/node.ts +++ b/packages/slate/src/transforms/node.ts @@ -100,6 +100,7 @@ export interface NodeTransforms { at?: Location match?: NodeMatch mode?: MaximizeMode + hanging?: boolean split?: boolean voids?: boolean } @@ -825,6 +826,7 @@ export const NodeTransforms: NodeTransforms = { at?: Location match?: NodeMatch mode?: MaximizeMode + hanging?: boolean split?: boolean voids?: boolean } = {}