In Firefox, `range.cloneContents()` returns an extra trailing '\n', when the document ends with a new-line character. This results in the offset length being off by one, so we need to subtract one to account for this.
* Upgrade `is-plain-object` to v5.0.0
The `is-plain-object` package recently had a major version upgrade that
broke libraries which import its default export, such as this one. This
causes issues when other packages in the same application require a
higher version of `is-plain-object`, resulting in an error originating
in Slate's codebase. To remedy this, Slate is now depending on
`is-plain-object@^5.0.0` and its import references across the codebase
have been updated.
Fixes#4499
* Add changeset
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* fix: check if data-slate-tring node is not null
Only reset the focus node of a selection when the node with attribute `data-slate-string` is defined
* fix: rewrite logic for checking triple click
* Add changeset
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* initial skeleton for jest testing
* run in serial mocha, then jest on slate-react only
* run-s without glob patterns https://github.com/yarnpkg/berry/issues/22
* don't run mocha on slate-react package
* use yarn run instead of run-s
* fix(editable component): reselect the range created by triple click
* Revert "fix(editable component): reselect the range created by triple click"
Reason: attaching a handler for `onClick` event is no longer needed.
* fix(react-editor): reselect DOMSelection when triple clicked
Reason: Triple clicking an element in Chrome will falsely set the focus node as the next sibling node with focusOffset 0
* test: add e2e test for triple click
* Migrate to yarn berry v3
* Fix yarn dependencies for linting
* Specifically invoke bash in yarn clean to make brace expansion work
* Upgrade cypress to 8.x to support yarn berry
* Try out yarn berry workaround for netlify
From https://answers.netlify.com/t/using-the-new-yarn-release-2-0-0-berry/8270
* Update .yarnrc.yml for syntax consistency
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* use rimraf for clean command with escaped glob pattern
* Use workspace:* resolution for workspace packages and rewrite yarn.lock
* set workspace package versions explicit again
* update peer dependencies
* disable import/named for ts and tsx files
* Replace 'key' with 'key=true' wherever babel complains
* replace all instances of key to someKey in tests to satisfy eslint and babel
* remove unnecessary yarn packageExtension and remove cross-env dependency
* upgrade yarn to latest
* Upgrade next.js to 10.x to support yarn berry
* update .yarnrc to satisfy netlify
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* [slate-react]: fix selection bugs when multiple editors share value
The KEY_TO_ELEMENT weakmap must be scoped to the instance to avoid collisions between multiple editors.
This is solved by wrapping it in another WeakMap keyed on the editor object, that returns the KEY_TO_ELEMENT Weakmap for that editor.
* Add changeset
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* fix(android): Fix mark is not inputed on insert text in android
* add changeset
* null mark only when mark exist
Co-authored-by: surya darma <budi.surya@kumparan.com>
* fix(android): clipboard application/x-slate-fragment is missing on paste in android
* add event onCut
* add changeset
* make slate fragment available when props onPaste, call preventDefault
* .
* get the fragment from text/html when it missing
* remove setData
* use getClipboardData instead of hooks
* Do not needlessly JSON.stringify() the whole editor
* Refactor based on feedback
* Linting fix for error messages
* linting fix
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* use native character insertion to fix browser/OS text features. (flickering spellcheck, autocorrect, text shortcuts, etc.)
move some checks into previous if statement, remove commented out code
move native behavior into `slate-react`, and remove any external interface
dont use native editing if marks are set, as a new node will be inserted
match -> above
remove nativeOperationsQueue from editor
bail out of native queueing and immediately flush events if non insert_text operation is being applied.
* Convert TextString to a functional component
* Batch normalization of native op application
* Add changeset
* only proceed as native event if single character non-special character or space, to limit potential bad side effects.
* Revert "fix ime double input with mark"
* Comment wording tweak
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* Comment wording tweak
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* Comment wording tweak
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* Comment wording tweak
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* Comment wording tweak
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
Co-authored-by: Ludwig Pettersson <luddep@gmail.com>
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* Remove fast-deep-equal in favour of a custom slate-specific equality check that only supports nested objects
* Add array comparison to deep equal. Fix bug with multiple nested objects.
* test: add test case for bug
* prefer next will transforming selection in remove_node
* add remove_node test
* Add changeset
* review: handle nested blocks
* refactor
* Revert "refactor"
This reverts commit 45a8aab7cb.
Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
* Update `findDocumentOrShadowRoot` to return undefined instead of throwing unnecessarily
* Small refactoring to improve the diff for reviewers
* Add changeset for patch
* Update new-trainers-peel.md
* Resolve PR comments
* Revert undefined checks, return window.document and update changeset
* Simplify findDocumentOrShadowRoot based on PR feedback
* Re-run CI
Thanks everyone for your review and thanks @ben10code for your first contribution!
