1
0
mirror of https://github.com/ianstormtaylor/slate.git synced 2025-03-06 05:49:47 +01:00

557 Commits

Author SHA1 Message Date
Alan Christopher Thomas
996edd19f5 Fix insertTextAtRange selection ()
* Make a test case for buggy insertTextAtRange selection behavior

* Insert text at previous path, not selection key, closes 
2018-10-15 15:48:00 -07:00
Dundercover
7192a97600 Add range comparison methods to Point ()
* Rename compare function in path-utils to compareOfSameSize
To make way for a new function that makes a full comparison

* Add compare function to path-utils that handles paths of different sizes

* Add function isAfterRange to Point

* Add function isBeforeRange to Point

* Add function isAtStartOfRange to Point

* Add function isAtEndOfRange to Point

* Add function isInRange to Point

* Add range comparison methods to the documentation of the Point model

* Remove `compareOfSameSize` in `path-utils.js`
Using `compare` instead

* Add `Point.isBeforePoint`

* Add `Point.isAfterPoint`

* Use own methods internally for range comparisons in `Point`

* Return null if paths don't finally match in `compare` method of `path-utils`
To convey that it is not a normal scenario

* Add first test for `Point` model (testing `isAfterPoint`)

* Add tests for `Point.isAfterPoint`

* Add tests for `Point.isBeforePoint`

* Add tests for `Point.isAfterRange`

* Add tests for `Point.isBeforeRange`

* Add tests for `Point.isAtEndOfRange`

* Add tests for `Point.isAtStartOfRange`

* Add tests for `Point.isInRange`
2018-10-15 15:44:09 -07:00
Ian Storm Taylor
d7123453c2 Publish
- slate-react@0.19.3
2018-10-10 09:52:54 -07:00
Ian Storm Taylor
6168ce932e fix editor resolution, remove constructor 2018-10-10 09:51:18 -07:00
Ian Storm Taylor
f939d168af Publish
- slate-base64-serializer@0.2.72
 - slate-html-serializer@0.7.11
 - slate-hyperscript@0.11.2
 - slate-plain-serializer@0.6.11
 - slate-prop-types@0.5.2
 - slate-react@0.19.2
 - slate@0.42.2
2018-10-09 18:46:54 -07:00
Ian Storm Taylor
3528bb7366 fix plugins stack ordering and defaulting 2018-10-09 18:43:47 -07:00
Ian Storm Taylor
7304c9b343 Publish
- slate-base64-serializer@0.2.71
 - slate-html-serializer@0.7.10
 - slate-hyperscript@0.11.1
 - slate-plain-serializer@0.6.10
 - slate-prop-types@0.5.1
 - slate-react@0.19.1
 - slate@0.42.1
2018-10-09 15:11:57 -07:00
Ian Storm Taylor
bd24739411 fix to pass editor to queries 2018-10-09 15:06:35 -07:00
Ian Storm Taylor
02c0f8e763 Publish
- slate-base64-serializer@0.2.70
 - slate-html-serializer@0.7.9
 - slate-hyperscript@0.11.0
 - slate-plain-serializer@0.6.9
 - slate-prop-types@0.5.0
 - slate-react@0.19.0
 - slate@0.42.0
2018-10-09 14:17:15 -07:00
Ian Storm Taylor
9f53d60bd1 remove packages-specific readme 2018-10-09 14:11:20 -07:00
Ian Storm Taylor
6ece0158bf add packages section to readme 2018-10-09 14:10:02 -07:00
Ian Storm Taylor
7a71de387c
Add controller ()
* fold Stack into Editor

* switch Change objects to be tied to editors, not values

* introduce controller

* add the "commands" concept

* convert history into commands on `value.data`

* add the ability to not normalize on editor creation/setting

* convert schema to a mutable constructor

* add editor.command method

* convert plugin handlers to receive `next`

* switch commands to use the onCommand middleware

* add queries support, convert schema to queries

* split out browser plugin

* remove noop util

* fixes

* fixes

* start fixing tests, refactor hyperscript to be more literal

* fix slate-html-serializer tests

* fix schema tests with hyperscript

* fix text model tests with hyperscript

* fix more tests

* get all tests passing

* fix lint

* undo decorations example update

* update examples

* small changes to the api to make it nicer

* update docs

* update commands/queries plugin logic

* change normalizeNode and validateNode to be middleware

* fix decoration removal

* rename commands tests

* add useful errors to existing APIs

* update changelogs

* cleanup

* fixes

* update docs

* add editor docs
2018-10-09 14:03:27 -07:00
Ian Storm Taylor
e6372d829a Publish
- slate-base64-serializer@0.2.69
 - slate-html-serializer@0.7.8
 - slate-hyperscript@0.10.8
 - slate-plain-serializer@0.6.8
 - slate-prop-types@0.4.67
 - slate-react@0.18.11
 - slate-simulator@0.4.67
 - slate@0.41.3
2018-10-09 12:49:32 -07:00
Kaspars Dancis
b1ec914467 Replace "zero width whitspace" with "zero width no break" character ()
This fixes https://github.com/ianstormtaylor/slate/issues/2231 where
a rogue empty line appears before an inline block.
2018-10-09 12:30:01 -07:00
inkubux
933c938765 Fix delete undo ()
* Fix undo after a selection snapshot

* Add a test to cover the text deletion case

* Fix lint

* Use the new whitoutMerging flag instead

* cleanup + fix function call
2018-10-09 12:13:03 -07:00
Kaspars Dancis
1ff050265b Fix an occasional crash in Firefox in isInEditor ()
* Fix an occasional crash in Firefox in isInEditor

* Update content.js
2018-10-05 14:25:32 -07:00
Bryan Haakman
10e8ab4db6 serialize path as well in Operation.toJSON ()
* serialize path as well in Operation.toJSON

* add on the next statement instead
2018-10-04 09:39:34 -07:00
Dmitry Zarva
dda0628c04 fix activeMarks for intersecting marks text () 2018-10-04 09:14:34 -07:00
Ian Storm Taylor
d84f5072c1
Fix normalizing dirty paths ()
#### Is this adding or improving a _feature_ or fixing a _bug_?

Fix.

#### What's the new behavior?

The dirty paths in a change are now transformed against incoming operations, such that they don't get out of sync as normalizations occur. This is a rough pass to get correctness and the bug fixed, and we can later optimize lots of the little details for performance.

#### Have you checked that...?

<!-- 
Please run through this checklist for your pull request: 
-->

* [x] The new code matches the existing patterns and styles.
* [x] The tests pass with `yarn test`.
* [x] The linter passes with `yarn lint`. (Fix errors with `yarn prettier`.)
* [x] The relevant examples still work. (Run examples with `yarn watch`.)

#### Does this fix any issues or need any specific reviewers?

Fixes: 
Fixes: 
Fixes: 
2018-10-02 15:57:48 -07:00
Ian Storm Taylor
9ed08c1544 remove debugger 2018-10-02 08:36:27 -07:00
Ian Storm Taylor
e7ab7f8279 cleanup object type checking and interface 2018-09-27 16:36:37 -07:00
Ian Storm Taylor
aba8f19d0e Publish
- slate-base64-serializer@0.2.68
 - slate-html-serializer@0.7.7
 - slate-hyperscript@0.10.7
 - slate-plain-serializer@0.6.7
 - slate-prop-types@0.4.66
 - slate-react@0.18.10
 - slate-simulator@0.4.66
 - slate@0.41.2
2018-09-26 13:20:34 -07:00
Ian Storm Taylor
7b4eca5e16 Merge branch 'master' of github.com:ianstormtaylor/slate 2018-09-26 13:12:42 -07:00
Ian Storm Taylor
af8432f639 fix onClick when not finding a node 2018-09-26 13:12:35 -07:00
Grey Osten
329dac72d3 Normalize copying void inline nodes ()
When a void inline nodes is selected along with other text/content it can be copied to the clipboard. When it’s the only thing selected it is ignored because anything marked contentedtiable=false is.
Updated isInEditor to return true if a contenteditable=false has a parent that is a void inline node.
2018-09-22 11:13:22 -07:00
Alan Christopher Thomas
0f5d95e98e Merge decorations from multiple plugins ()
* Merge decorations from multiple plugins

Previously, `decorateNode` would search the plugin stack for the first
`decorateNode` handler that returned a value. Now, it will call the
`decorateNode` handler on every plugin in the stack and merge their results
together.

* Call List() to instantiate empty list instead of using new keyword

* Fix linting errors and use Immutable's flatten()

* Use boolean flatten() argument for clarity (shallow flatten)
2018-09-22 11:12:12 -07:00
Ian Storm Taylor
bf9b03e634 Publish
- slate-base64-serializer@0.2.67
 - slate-html-serializer@0.7.6
 - slate-hyperscript@0.10.6
 - slate-plain-serializer@0.6.6
 - slate-prop-types@0.4.65
 - slate-react@0.18.9
 - slate-simulator@0.4.65
 - slate@0.41.1
2018-09-21 15:09:49 -07:00
Ian Storm Taylor
75ef8a5232 simplify parent dirty key logic 2018-09-21 15:03:16 -07:00
Ian Storm Taylor
4e9d262f9b fix normalization for non-node operations 2018-09-21 15:01:17 -07:00
Ian Storm Taylor
ca6920a88f Publish
- slate-base64-serializer@0.2.66
 - slate-html-serializer@0.7.5
 - slate-hyperscript@0.10.5
 - slate-plain-serializer@0.6.5
 - slate-prop-types@0.4.64
 - slate-react@0.18.8
 - slate-simulator@0.4.64
 - slate@0.41.0
2018-09-21 11:19:48 -07:00
Ian Storm Taylor
c9cf16d019
refactor normalization to be operations-based ()
#### Is this adding or improving a _feature_ or fixing a _bug_?

Improvement.

#### What's the new behavior?

This changes the normalization logic to be operations (and `key`) based, instead of the current logic which is more haphazard, and which has bugs that lead to non-normalized documents in certain cases.

#### How does this change work?

Now, every time a change method is called, after it applies its operations, those operations will be normalized. Based on each operation we can know exactly which nodes are "dirty" and need to be re-validated.

This change also makes it easy for the `withoutNormalizing` (previously `withoutNormalization`) helper to be much more performant, and only normalize the "dirty" nodes instead of being forced to handle the entire document.

To accommodate this new behavior, the old "operation flags" have been removed, replaced with a set of more consistent helpers:

- `withoutNormalizing`
- `withoutSaving`
- `withoutMerging`

All of them take functions that will be run with the desired behavior in scope, similar to how Immutable.js's own `withMutations` works. Previously this was done with a more complex set of flags, which could be set and unset in a confusing number of different ways, and it was generally not very well thought out. Hopefully this cleans it up, and makes it more approachable for people.

We also automatically use the `withoutNormalizing` helper function for all of the changes that occur as part of schema `normalize` functions. Previously people had to use `{ normalize: false }` everywhere in those functions which was error-prone.

With this new architecture, you sure almost never need to think about normalization. Except for cases where you explicitly want to move through an interim state that is invalid according to Slate's default schema or your own custom schema. In which case you'd use `withoutNormalizing` to allow the invalid interim state to be moved through.

#### Have you checked that...?

* [x] The new code matches the existing patterns and styles.
* [x] The tests pass with `yarn test`.
* [x] The linter passes with `yarn lint`. (Fix errors with `yarn prettier`.)
* [x] The relevant examples still work. (Run examples with `yarn watch`.)

#### Does this fix any issues or need any specific reviewers?

Fixes: 
Fixes: 
Fixes: 
Fixes: 
Fixes: 
Fixes: 
Fixes: 
2018-09-21 11:15:04 -07:00
Ian Storm Taylor
da93937b19 fix benchmarks 2018-09-21 09:56:20 -07:00
Ian Storm Taylor
fd1832c73f Publish
- slate-base64-serializer@0.2.65
 - slate-hotkeys@0.2.5
 - slate-html-serializer@0.7.4
 - slate-hyperscript@0.10.4
 - slate-plain-serializer@0.6.4
 - slate-prop-types@0.4.63
 - slate-react@0.18.7
 - slate-simulator@0.4.63
 - slate@0.40.4
2018-09-21 09:43:39 -07:00
Ian Storm Taylor
fd87c746f8 fix versions... 2018-09-21 09:42:05 -07:00
Ian Storm Taylor
018ada8b88 fix selection.marks preservation from 2018-09-18 10:08:33 -07:00
Nicolas Gaborit
4749cfc8b1 Actually fix marks being cleared on selection events ()
* Fix marks being cleared on selection events

* Fix mistake
2018-09-18 09:49:18 -07:00
Bjørge Næss
3e7116dce1 Gracefully handle permission denied error when checking for element.nodeType () 2018-09-17 18:38:49 -07:00
Nicolas Gaborit
ea950ac1af Fix marks being cleared on selection events () 2018-09-17 18:33:01 -07:00
Per-Kristian Nordnes
f75a274c0e Fix deprecated .move > .moveForward in the after plugin () 2018-09-17 18:28:22 -07:00
Damien Erambert
222f746e85 Avoid crash in updateSelection() in content when window.getSelection() returns null () 2018-09-17 18:27:10 -07:00
Per-Kristian Nordnes
6340469266
Fix deprecated moveToStartOf and moveToEndOf ()
In slate-react module (get-event-range)
2018-09-08 01:34:12 +02:00
Charley DAVID
405cef0225 Add support for validating functions inside schema's rules ()
* Add specs, defaults, and documentation to next/previous rule properties

* Add comparator function support for kind/object, type, data, and mark
2018-09-04 13:14:20 -07:00
Ian Storm Taylor
6369d0523a Publish
- slate-react@0.18.5
2018-09-04 12:00:41 -07:00
Eric Edem
3db717761e fix(content): attach the right onNativeSelectionChange. ()
This undoes a recent change https://github.com/ianstormtaylor/slate/pull/2131

Which hooked up `this.handlers.onNativeSelectionChange` to `'selectionchange'` as well as `this.handlers.onBeforeInput` to `'beforeinput'`.

It turns out that in order to fix the iOS issues, we only needed the change to `onBeforeInput`. The corect handler for `'selectionchange'` is the instance method `this.onNativeSelectionChange`. This broke a whole bunch of focus related issues.
2018-09-04 10:36:48 -07:00
Ian Storm Taylor
54611b7dd7 Publish
- slate-react@0.18.4
2018-08-29 14:03:31 -07:00
Eric Edem
9d0546fad3 fix(content): use handlers that actually exist in event listeners ()
* fix(content): use handlers that actually exist in event listeners

In a recent change, handlers now only exist in `Content#handlers`, but there were still a couple of places where they were being dereferenced directly from the instance. This was causing some side effects in iOS.

Fixes 
Fixes 

* fix(content): also fix removeEventListeners
2018-08-29 12:32:48 -07:00
Ian Storm Taylor
ba9b79112e Publish
- slate-base64-serializer@0.2.63
 - slate-html-serializer@0.7.2
 - slate-hyperscript@0.10.2
 - slate-plain-serializer@0.6.2
 - slate-prop-types@0.4.61
 - slate-react@0.18.3
 - slate-simulator@0.4.61
 - slate@0.40.2
2018-08-24 09:01:31 -07:00
Irwan Fario Subastian
dfc41d1697 Fix incorrect history stack ()
* update yarn.lock

* fix typo that cause select operation clearing redo
2018-08-24 08:30:37 -07:00
Ian Storm Taylor
584ffec626 Publish
- slate-base64-serializer@0.2.62
 - slate-html-serializer@0.7.1
 - slate-hyperscript@0.10.1
 - slate-plain-serializer@0.6.1
 - slate-prop-types@0.4.60
 - slate-react@0.18.2
 - slate-simulator@0.4.60
 - slate@0.40.1
2018-08-23 13:54:58 -07:00
Ian Storm Taylor
8409e490c9 tweak maximum schema iterations logic, addresses 2018-08-23 13:53:29 -07:00