When drag-and-dropping nodes within the same editor, the removal of
the dragged nodes can cause paths and offsets to change. This is
really hard to compensate for.
Instead of compensating for it, rearranging the order things happen
mean we are always working with a document in a reasonable state.
Now, we:
1. Fire a MouseUp event on `event.target` (because we haven't done
anything, it's guaranteed to exist)
2. Save the range we're dragging (for later)
3. Select the target range (because we haven't deleted anything, this
is still valid)
4. Delete the range we're dragging (this will automatically adjust the
editor's selection)
5. Insert the dragged fragment at the current range
No matter where we're dragging from or to, these should all be
pointing at places that both exist, and haven't changed.
* fix React warnings on renderMark, renderBlock, renderDecoration
* included decorateNode and relocated code into constants in EventHandler
* Put decorateNode and render handlers into a seperate file.
* fix indentation
* overlooked indentation.
* deleteBackwardAtRange now works when offset is equal to n
Closes#2965
* Adds test to verify behaviour of `deleteBackwardAtRange` when offset===length
* Fix typo & remove useless check
* No need to check the end of the selection, as this part is called after the
`deleteExpanded` call. Selection is collapsed at this point.
* Fix insertFragment selection not place properly
It were trying to add those marks that are passed to the function to the existing once,
but it should replace them instead.
Example error behavior was:
* put cursor at the end of the marked text
* toggle marks
* enter text
expected:
text is being added without toggled marks
actual:
text is added with those marks applied
* Mutate newDirtyPaths instead of creating a new array every iteration
* Switch to map + Array.prototype.concat.apply to improve readability
* Update editor.js
* fix: Unknown event handler property `onEvent`
```
index.js:1 Warning: Unknown event handler property `onEvent`. It will be ignored.
in div (created by Content)
in Content (created by Editor)
```
* fix: make onEvent required
Seems this prop is provided in `component/editor.js`
* fix(firefox): fixed the bug that happens when changing the focus from one field to another
* Publish
- slate-base64-serializer@0.2.69
- slate-html-serializer@0.7.8
- slate-hyperscript@0.10.8
- slate-plain-serializer@0.6.8
- slate-prop-types@0.4.67
- slate-react@0.18.11
- slate-simulator@0.4.67
- slate@0.41.3
* Publish
- slate-base64-serializer@0.2.70
- slate-html-serializer@0.7.9
- slate-hyperscript@0.10.9
- slate-plain-serializer@0.6.9
- slate-prop-types@0.4.68
- slate-react@0.18.12
- slate-simulator@0.4.68
- slate@0.41.4
* Publish
- slate-react@0.18.13
* Revert "Fix an occasional crash in Firefox in isInEditor (#2229)"
This reverts commit 1ff050265bbcb8e6d5b5bbf9dc8839f1c6a2ddef.
* fix(firefox): added postinstall script to the main project
* fix(firefox): removed error causing line
* fix(firefox): added the right fix for this
* fix(firefox): added the best fix for this
* fix(firefox): made the range a constant
* fix(firefox): added the removeAllRanges inside the if wrapper
* fix(lint): fixed lint error
* fix(versions): removed changes for the package.json files
* fix(versions): removed remaining changes for the package.json files
* fix(conflict): fixed the issue that resolving the conflicts caused last time
* fix(lint): fixed the last lint error
* chore(content): moved comment in setTimeout to see why git is not showing conflicts locally
* Add debug-mutations
* Fix linting
* Add debug-mutations to o core plugins
* Fix debug output
* Add comment about debug statement
* Add comment explaining the building of debug output object
* Add framework for mutations and mutation observer
* Working splitBlock and mergeBlock
* many things working but not autocorrect
* All later tests pass
* Before adding isComposing to composition-manager
* Fixit
* fix enter enter backspace backspace
* Pass all tests except space-back-space-back
* Passes all tests I think but doesn't continuous backspace or select delete
* Passes all tests and delete selection work
* Fix for merge
* Passes all tests including typing hello world on new line and enter
* Before switching to a function
* Fix enter after last char
* Fix it wasn't me. no. bug
* Remove timeout delay on compositionEnd and everthing works except it wasnt me. no.
* Passes all tests but need to add tests for delete all and select delete
* Pass all tests
* Fix remove selection
* Added flush onCompositionEnd just in case
* Fix bugs for Android 8 split join and fix side effects on Android 9 to that fix
* Add comments to composition manager
* Clean up code
* Fix bug with delete range
* Add comments
* Fix focus lost bug on change examples
* Improve comments
* Rename clear to clearAction and a comment
* Rename lastEl to last.rootEl
* Remove isListening
* Rename vars
* Fix bug where changing to new example during a composition messes up update
* Add comment to switching examples in composition fix
* Improve comments
* Refactor
* Refactor removeNode
* Remove unused event callbacks
* Refactor connect
* Cleanup mutation plugin
* Remove unnecessary comments
* Remove readme
* Refactor ReactPlugin
* Refactor plugins and injection locations
* Remove dom-observer
* Remove is-input-data helpers
* Move fixSelectionInZeroWidthBlock
* Fix some linting and also a composition manager bug
* Fix linting and remove placeholder on Android
* Refactor
* Update composition-manager description
* Fix comment on composition manager
Co-Authored-By: Nick Anderson <tetramputechture@gmail.com>
This version of the method has drifted from `editor.findEventRange`,
and now crashes when it's being used. This commit fixes an import and
changes some code to match the new code in `editor.findEventRange`.
