mirror of https://github.com/ianstormtaylor/slate.git synced 2025-03-14 10:19:43 +01:00

History

Fix bug: setting selection from contentEditable:false element causes crash (#4584 )

* Fix bug: setting selection from contentEditable:false element causes crash

Fixes https://github.com/ianstormtaylor/slate/issues/4583

When clicking some text in a `contentEditable:false` element, if the
handler for this sets the selection, Slate crashes. Slate tries to find
a Slate range for the text that was clicked on, but there is no such
range, because the text is inside a `contentEditable:false` element.
Slate seems to be making a bad assumption that the current DOM selection
necessarily corresponds to a Slate range, but this is not the case if
the user just clicked into an element with `contentEditable: false`.
To fix this, I changed `exactMatch: false` to `exactMatch: true`,
which seems to mean "fail gracefully if there is no exact match".

* changeset

* Revert "Fix bug: setting selection from contentEditable:false element causes crash"

This reverts commit 71234284cd454993b139ce065a9ab2db431abce8.

* Unconflate exactMatch flag: add suppressThrow flag for separate behavior

* Fix bug: setting selection from contentEditable:false element causes crash

Fixes #4583

When clicking some text in a `contentEditable:false` element, if the
handler for this sets the selection, Slate crashes. Slate tries to find
a Slate range for the text that was clicked on, but there is no such
range, because the text is inside a `contentEditable:false` element.
Slate seems to be making a bad assumption that the current DOM selection
necessarily corresponds to a Slate range, but this is not the case if
the user just clicked into an element with `contentEditable: false`.

2021-10-13 11:45:00 -07:00

config.json

rename master to main

2021-04-01 13:40:25 -04:00

curly-timers-watch.md

Don't remove selection when hovering over a non-selectable DOM element (#4577 )

2021-10-11 17:39:53 -07:00

fast-shrimps-begin.md

Allow passing custom editor creator to slate-hyperscript createEditor (#4555 )

2021-10-11 17:33:52 -07:00

lovely-goats-argue.md

Only use Slate Provider's value prop as initial state (#4540 )

2021-10-11 17:38:02 -07:00

merge-nodes-issue

Do not remove empty node in merge operation if it is first children i… (#4287 )

2021-08-05 10:38:31 -07:00

README.md

rename master to main

2021-04-01 13:40:25 -04:00

shy-brooms-notice.md

Fix bug: setting selection from contentEditable:false element causes crash (#4584 )

2021-10-13 11:45:00 -07:00

README.md

Changesets

Hello and welcome! This folder has been automatically generated by @changesets/cli, a build tool that works with multi-package repos, or single-package repos to help you version and publish your code. You can find the full documentation for it in our repository

We have a quick list of common questions to get you started engaging with this project in our documentation