mirror/tomahawk
1
0
Fork 0
mirror of https://github.com/tomahawk-player/tomahawk.git synced 2025-08-12 00:54:20 +02:00
Code Issues Releases Wiki Activity

Don't paint a hover background during drag & drop, when you can't drop something on a sidebar item, e.g. groups, labels etc.

Browse Source
This commit is contained in:
Christian Muehlhaeuser
2016-02-23 02:15:45 +01:00
parent 285333d43b
commit 2ab9418a9e
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/tomahawk/sourcetree/SourceTreeView.cpp
View File

@@ -827,7 +827,7 @@ SourceTreeView::dragMoveEvent( QDragMoveEvent* event )
{ {
case SourcesModel::StaticPlaylist: case SourcesModel::StaticPlaylist:
case SourcesModel::CategoryAdd: case SourcesModel::CategoryAdd:
case SourcesModel::Source: //drop to send tracks to peers case SourcesModel::Source: // drop to send tracks to peers
m_delegate->hovered( index, event->mimeData() ); m_delegate->hovered( index, event->mimeData() );
if ( index != m_dropIndex ) if ( index != m_dropIndex )
dataChanged( index, index ); dataChanged( index, index );
@@ -851,8 +851,10 @@ SourceTreeView::dragMoveEvent( QDragMoveEvent* event )
// Playlists are accepted always since they can be dropped anywhere // Playlists are accepted always since they can be dropped anywhere
//tDebug() << Q_FUNC_INFO << "Accepting"; //tDebug() << Q_FUNC_INFO << "Accepting";
event->setDropAction( Qt::CopyAction ); event->setDropAction( Qt::CopyAction );
m_dropIndex = QPersistentModelIndex( index );
} }
m_dropIndex = QPersistentModelIndex( index ); else
m_dropIndex = QPersistentModelIndex();
} }
else if ( DropJob::acceptsMimeData( event->mimeData(), DropJob::Playlist | DropJob::Artist | DropJob::Album, DropJob::Create ) ) else if ( DropJob::acceptsMimeData( event->mimeData(), DropJob::Playlist | DropJob::Artist | DropJob::Album, DropJob::Create ) )
{ {
@@ -949,7 +951,8 @@ SourceTreeView::keyPressEvent( QKeyEvent* event )
void void
SourceTreeView::paintEvent( QPaintEvent* event ) SourceTreeView::paintEvent( QPaintEvent* event )
{ {
if ( m_dragging && !m_dropRect.isEmpty() ) /* Draw drag & drop hover background */
if ( m_dragging && !m_dropRect.isEmpty() && m_dropIndex.isValid() )
{ {
QPainter painter( viewport() ); QPainter painter( viewport() );
const QRect itemRect = visualRect( m_dropIndex ); const QRect itemRect = visualRect( m_dropIndex );